feat(utils): add proxy set #325
Conversation
- `initialValues` signature match native set - use `Array.from` during instantiation - wrap object in proxy when calling `has` - `toJSON` match native set behavior
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/valtio/2PWcViXEBHPsgp67XunpWC6ZTbua |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 353f0cf:
|
That's a very nice idea! |
- use type instead of interface - update initialValues signature - fix object check - use splice instead of reassignment to avoid creating a new proxy - add tests for proxySet internal
|
Amazing, do you want me to add an example before we merge? I'm trying to figure out a good use case(a simple one) for using Set. I thought first about the todo but most of the operations relies on the todo id which makes sense |
|
You can work on examples in a separate PR. Can you add a short section in readme? |
Sure, no problem I'll do this later today when I'm back. I've also pushed another commit to remove the |
|
Added a tiny readme section let me know if it's enough |
I created a new PR as I rebased from fix(core): expose canProxy in handler #321. Below is the output of the tests that are generated. I can of course add more if needed.
I was thinking to add an example as well inside the example folder
todo-with-proxySetor whatever the name. Let me know if you think it's worth it