Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PointerLockControls): Remove browser prefixes for "MouseEvent.movement" props #385

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

satelllte
Copy link
Contributor

About

The browser support for these properties is stabilized for years (since 2015).

https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/movementX
https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/movementY

Checklist

  • N/A Documentation updated
  • N/A Storybook entry added
  • Ready to be merged

Copy link

codesandbox-ci bot commented Nov 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@satelllte satelllte marked this pull request as ready for review November 4, 2024 14:01
@satelllte satelllte changed the title PointerLockControls: Remove browser prefixes for "MouseEvent.movement" props chore(PointerLockControls): Remove browser prefixes for "MouseEvent.movement" props Nov 4, 2024
@satelllte
Copy link
Contributor Author

Same change for the original Three.js implementation of PointerLockControls: mrdoob/three.js#29802

@CodyJasonBennett CodyJasonBennett merged commit 6b51b6d into pmndrs:main Nov 12, 2024
3 checks passed
@satelllte satelllte deleted the pointer_lock_ts branch November 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants