Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] fix(createPortal): ensure container is wrapped in Scene #3247

Open
wants to merge 2 commits into
base: v9
Choose a base branch
from

Conversation

CodyJasonBennett
Copy link
Member

Fixes #2725.

Copy link

codesandbox-ci bot commented May 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d92501c:

Sandbox Source
example Configuration

@krispya
Copy link
Member

krispya commented May 3, 2024

I think a better solution is to have scene always point to the root scene, which I think is expected behavior, and then add another prop to the store called container or root that points to the portal root. When not in a portal it would just be the same as scene. This way you always have full access to the tree even if inside of a portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants