Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to encode invalid sRGB textures #2762

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

CodyJasonBennett
Copy link
Member

Will only try to encode textures as sRGB when they are a valid RGBA8 texture as per mrdoob/three.js#23129.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 347f121:

Sandbox Source
example Configuration

@drcmda drcmda merged commit 6a0ece0 into master Feb 16, 2023
@CodyJasonBennett CodyJasonBennett deleted the fix/valid-srgb branch February 16, 2023 22:46
renovate bot referenced this pull request in ziyadedher/ziyadedher Feb 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.1` ->
`8.11.2`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.1/8.11.2)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/compatibility-slim/8.11.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/confidence-slim/8.11.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.1...v8.11.2)

#### What's Changed

- docs: fix broken titles on events.mdx by
[@&#8203;verekia](https://togithub.com/verekia) in
[https://github.com/pmndrs/react-three-fiber/pull/2761](https://togithub.com/pmndrs/react-three-fiber/pull/2761)
- fix: memoize HMR, strict check constructors by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[https://github.com/pmndrs/react-three-fiber/pull/2757](https://togithub.com/pmndrs/react-three-fiber/pull/2757)
- fix: don't try to encode invalid sRGB textures by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2762](https://togithub.com/pmndrs/react-three-fiber/pull/2762)

#### New Contributors

- [@&#8203;verekia](https://togithub.com/verekia) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2761](https://togithub.com/pmndrs/react-three-fiber/pull/2761)

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.1...v8.11.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDIuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Mi4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher referenced this pull request in ziyadedher/ziyadedher Dec 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.11.1` ->
`8.11.2`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.11.1/8.11.2)
|
[![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/compatibility-slim/8.11.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.11.2/confidence-slim/8.11.1)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber</summary>

###
[`v8.11.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.11.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.11.1...v8.11.2)

#### What's Changed

- docs: fix broken titles on events.mdx by
[@&#8203;verekia](https://togithub.com/verekia) in
[https://github.com/pmndrs/react-three-fiber/pull/2761](https://togithub.com/pmndrs/react-three-fiber/pull/2761)
- fix: memoize HMR, strict check constructors by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[https://github.com/pmndrs/react-three-fiber/pull/2757](https://togithub.com/pmndrs/react-three-fiber/pull/2757)
- fix: don't try to encode invalid sRGB textures by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2762](https://togithub.com/pmndrs/react-three-fiber/pull/2762)

#### New Contributors

- [@&#8203;verekia](https://togithub.com/verekia) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2761](https://togithub.com/pmndrs/react-three-fiber/pull/2761)

**Full Changelog**:
pmndrs/react-three-fiber@v8.11.1...v8.11.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDIuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Mi4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
itsdouges pushed a commit to itsdouges/react-three-fiber that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants