-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] fix: forward StrictMode #2547
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0f23d3:
|
How do you feel about merging this? Seems like a good feature for us. |
We have to add this for sure, but wondering whether we should let people opt in/out between v8 and v9. |
As in a prop on |
Fair enough. I was moreso concerned about whether to backport as an opt-in flag to v8, but I'll leave it be since we'd just remove it in v9. |
Yeah and I think very few people would actually opt-in. It's one of those changes that is technically correct but certainly going to introduce users insulated from React's disruptive change a year later. |
Respects
React.StrictMode
from parent renderers in R3F's Canvas. Targeting v9 since this highlights a lot of bugs in surrounding libraries that we'll want to take care of. This should probably be implemented downstream in a major.