Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle touch start/end events as pointer over/out #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: handle touch start/end events as pointer over/out #46

wants to merge 3 commits into from

Conversation

milesflavel
Copy link
Collaborator

  • refactor: separate A11y state into 3 separate state variables
  • feat: handle touch start/end events as pointer over/out

Partially resolves #45 (comment)

@AlaricBaraou
Copy link
Collaborator

@milesflavel Do you mind explaining why we need onTouchStart / onTouchEnd ?
I'm fine with the other changes of this PR

@milesflavel
Copy link
Collaborator Author

@milesflavel Do you mind explaining why we need onTouchStart / onTouchEnd ? I'm fine with the other changes of this PR

I was running into situations where touch would result in the hovered state being set true, but it would never set itself false again. By explicitly binding the onTouchStart & onTouchEnd events, it resolved this problem.

The issues were loosely described in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Touch events behave inconsistently with A11y
2 participants
@milesflavel @AlaricBaraou