Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: various improvements #615

Closed
wants to merge 13 commits into from
Closed

wip: various improvements #615

wants to merge 13 commits into from

Conversation

aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Apr 1, 2019 •
edited
Loading

⚠️ Closed in favor of #632

I've been doing a ton of work on the Controller class today, so I figured I should show you asap, in case you have any concerns or comments. I will explain the changes I've made in a nice list once I'm confident they are working as expected. For now, this is only a draft PR. Cheers!

Closes #335
Closes #362
Closes #623
Closes #624
Closes #629

aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 1, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 2, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 2, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 2, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
aleclarson
aleclarson commented Apr 2, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
@drcmda

This comment has been minimized.

Sign in to view
aleclarson
aleclarson commented Apr 9, 2019
View reviewed changes
src/animated/Controller.ts Outdated Show resolved Hide resolved
src/animated/Controller.ts Show resolved Hide resolved
src/shared/helpers.ts Show resolved Hide resolved
src/useTransition.js Show resolved Hide resolved
src/useTransition.js Show resolved Hide resolved
src/animated/Controller.ts Show resolved Hide resolved
src/animated/Controller.ts Show resolved Hide resolved
src/animated/Controller.ts Show resolved Hide resolved
src/animated/Controller.ts Outdated Show resolved Hide resolved
src/animated/Controller.ts Show resolved Hide resolved
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 9, 2019
@drcmda
Copy link
Member

drcmda commented Apr 9, 2019

This pull request fixes 2 alerts when merging a6e3637 into 370856f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@aleclarson aleclarson mentioned this pull request Apr 9, 2019
Closed
aleclarson added a commit to aleclarson/react-spring-examples that referenced this pull request Apr 9, 2019
@aleclarson
fix: blackflag demo
f58e01c 
So it works with: pmndrs/react-spring#615
aleclarson added a commit to aleclarson/react-spring-examples that referenced this pull request Apr 9, 2019
@aleclarson
fix: notification-hub demo
b4d9baa 
So it works with: pmndrs/react-spring#615
aleclarson added a commit to aleclarson/react-spring-examples that referenced this pull request Apr 9, 2019
@aleclarson
fix: blackflag demo
0f0ed9b 
So it works with: pmndrs/react-spring#615
aleclarson added a commit to aleclarson/react-spring-examples that referenced this pull request Apr 9, 2019
@aleclarson
fix: notification-hub demo
c97e3e4 
So it works with: pmndrs/react-spring#615
@aleclarson aleclarson mentioned this pull request Apr 9, 2019
Closed
@aleclarson aleclarson force-pushed the wip-1 branch 4 times, most recently from 77d36f8 to 8a7b3ac Compare April 10, 2019 01:27
@pmndrs pmndrs deleted a comment from drcmda Apr 10, 2019
@pmndrs pmndrs deleted a comment from drcmda Apr 10, 2019
@drcmda
Copy link
Member

drcmda commented Apr 10, 2019

This pull request fixes 2 alerts when merging b9e4ff5 into ca4f2c7 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@drcmda
Copy link
Member

drcmda commented Apr 10, 2019

This pull request fixes 2 alerts when merging 0ba1693 into ca4f2c7 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@aleclarson aleclarson mentioned this pull request Apr 10, 2019
Closed
5 tasks
@aleclarson aleclarson closed this Apr 10, 2019
@pmndrs pmndrs locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drcmda drcmda drcmda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aleclarson @drcmda