Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutlinePass animation problem #68

Closed
erosb opened this issue Feb 23, 2018 · 4 comments
Closed

OutlinePass animation problem #68

erosb opened this issue Feb 23, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@erosb
Copy link

erosb commented Feb 23, 2018

Hello,

first of all thank you for your hard work on this library.

When I tried to use the OutlinePass effect, I found that it works well for static meshes, but when I try to play an animation, the outline does not follow the moving mesh parts. Is there any way to resolve this?

A minimal project for reproducing the problem is here: https://github.com/erosb/outlinepass-bug
After cloning,

  • run npm install && npm run-script build
  • load it with any static HTTP server
  • from the browser dev console run eg. playAnim("attack_3")

You can find it running here: http://erosb.github.io/outlinepass-bug/

Environment:

  • Tested in Chrome and Firefox
  • ubuntu 16.04
  • NVidia GeForce GTX 960

Thank you for your time.

@vanruesc
Copy link
Member

Hi,

thanks for the report!

The OutlinePass uses a custom depth comparison material which doesn't seem to implement skinning (and clipping planes).

I'll take a closer look at this tomorrow. Stay tuned 😄

@vanruesc vanruesc added the bug Something isn't working label Feb 23, 2018
@vanruesc
Copy link
Member

Fixed in [email protected].

RGBA Depth Depth Mask Outline Composite
rgba_depth depth_mask composite

@erosb
Copy link
Author

erosb commented Feb 24, 2018

You are awesome! Thanks a lot!

@vanruesc
Copy link
Member

Thank you, the code example you provided helped a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants