Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAO color (or GTAO?) #211

Closed
drcmda opened this issue Jun 21, 2020 · 9 comments
Closed

SSAO color (or GTAO?) #211

drcmda opened this issue Jun 21, 2020 · 9 comments
Labels
feature request New feature request

Comments

@drcmda
Copy link
Member

drcmda commented Jun 21, 2020

this is what it should look like

Screenshot 2020-06-21 at 09 24 48 copy

with postprocessing: https://codesandbox.io/s/ball-pit-1-o5ir0

Screenshot 2020-06-21 at 09 28 13

i know this isn't ground thuth AO but could we still set the AO color somehow? in this case i would like to make it red for instance.

@vanruesc
Copy link
Member

could we still set the AO color somehow?

Yes, that should be possible. I'll look into it when I get a chance.

@vanruesc vanruesc added the feature request New feature request label Jun 21, 2020
vanruesc added a commit that referenced this issue Jul 6, 2020
@vanruesc
Copy link
Member

vanruesc commented Jul 6, 2020

Added support for colorized ambient occlusion in [email protected].

@vanruesc vanruesc closed this as completed Jul 6, 2020
@vanruesc
Copy link
Member

vanruesc commented Jul 6, 2020

Sandbox for reference: https://codesandbox.io/s/ball-pit-1-vlhu6

@drcmda
Copy link
Member Author

drcmda commented Jul 6, 2020

thanks, it looks awesome! the sandbox you posted had a halo for some reason, but i updated mine and it's exactly the effect i looked for https://codesandbox.io/s/ball-pit-1-mvkqs?file=/src/App.js

@drcmda
Copy link
Member Author

drcmda commented Jul 7, 2020

@vanruesc from this question by @edankwan : https://twitter.com/edankwan/status/1280407226411290625 would that be possible, too? to deal out individual colors for objects?

@vanruesc
Copy link
Member

vanruesc commented Jul 7, 2020

I don't know if that can be done with the current scalable ambient obscurance algorithm. I'll try adding light bounce based on @gkjohnson's GTAO implementation when I find some time.

@vanruesc
Copy link
Member

vanruesc commented Jul 7, 2020

Opened a new issue for the light bounce feature: #214.

@gkjohnson
Copy link

@vanruesc @drcmda just note that without actual surface information (diffuse color, roughness, metalness) of the objects before shadows are applied bounce light won't really be able to "reveal" any real information in shadowed areas. When I was working on it I found that it wound up muddying an image in more complex cases because of this but in simple cases it didn't look too bad. Perhaps one day we'll have deferred rendering and we'll have more information for these effects. I think it would be a good option, though!

The new AO color looks great, too.

@vanruesc
Copy link
Member

vanruesc commented Jul 7, 2020

@gkjohnson Thanks for the heads-up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

3 participants