feat: dev store with unstable_derive #2852

dai-shi · 2024-12-11T11:50:45Z

Thanks to unstable_derive, we can implement dev store with it.

vercel · 2024-12-11T11:50:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 23, 2024 3:20am

codesandbox-ci · 2024-12-11T11:51:18Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions · 2024-12-11T11:51:53Z

Size Change: +1.11 kB (+1.22%)

Total Size: 92 kB

Filename	Size	Change
`./dist/esm/vanilla.mjs`	4.24 kB	+250 B (+6.26%)	🔍
`./dist/system/vanilla.development.js`	4.34 kB	+267 B (+6.55%)	🔍
`./dist/umd/vanilla.development.js`	5.66 kB	+300 B (+5.6%)	🔍
`./dist/umd/vanilla.production.js`	2.85 kB	+2 B (+0.07%)
`./dist/vanilla.js`	5.55 kB	+294 B (+5.6%)	🔍

ℹ️ View Unchanged

Filename	Size
`./dist/babel/plugin-debug-label.js`	932 B
`./dist/babel/plugin-react-refresh.js`	1.14 kB
`./dist/babel/preset.js`	1.41 kB
`./dist/esm/babel/plugin-debug-label.mjs`	1 kB
`./dist/esm/babel/plugin-react-refresh.mjs`	1.19 kB
`./dist/esm/babel/preset.mjs`	1.49 kB
`./dist/esm/index.mjs`	62 B
`./dist/esm/react.mjs`	1.4 kB
`./dist/esm/react/utils.mjs`	746 B
`./dist/esm/utils.mjs`	67 B
`./dist/esm/vanilla/utils.mjs`	5.04 kB
`./dist/index.js`	242 B
`./dist/react.js`	1.44 kB
`./dist/react/utils.js`	1.39 kB
`./dist/system/babel/plugin-debug-label.development.js`	1.1 kB
`./dist/system/babel/plugin-debug-label.production.js`	775 B
`./dist/system/babel/plugin-react-refresh.development.js`	1.29 kB
`./dist/system/babel/plugin-react-refresh.production.js`	928 B
`./dist/system/babel/preset.development.js`	1.59 kB
`./dist/system/babel/preset.production.js`	1.14 kB
`./dist/system/index.development.js`	252 B
`./dist/system/index.production.js`	183 B
`./dist/system/react.development.js`	1.56 kB
`./dist/system/react.production.js`	864 B
`./dist/system/react/utils.development.js`	860 B
`./dist/system/react/utils.production.js`	462 B
`./dist/system/utils.development.js`	257 B
`./dist/system/utils.production.js`	187 B
`./dist/system/vanilla.production.js`	2.14 kB
`./dist/system/vanilla/utils.development.js`	5.25 kB
`./dist/system/vanilla/utils.production.js`	3.14 kB
`./dist/umd/babel/plugin-debug-label.development.js`	1.08 kB
`./dist/umd/babel/plugin-debug-label.production.js`	852 B
`./dist/umd/babel/plugin-react-refresh.development.js`	1.27 kB
`./dist/umd/babel/plugin-react-refresh.production.js`	1 kB
`./dist/umd/babel/preset.development.js`	1.54 kB
`./dist/umd/babel/preset.production.js`	1.22 kB
`./dist/umd/index.development.js`	383 B
`./dist/umd/index.production.js`	328 B
`./dist/umd/react.development.js`	1.57 kB
`./dist/umd/react.production.js`	936 B
`./dist/umd/react/utils.development.js`	1.53 kB
`./dist/umd/react/utils.production.js`	1.01 kB
`./dist/umd/utils.development.js`	399 B
`./dist/umd/utils.production.js`	342 B
`./dist/umd/vanilla/utils.development.js`	6.24 kB
`./dist/umd/vanilla/utils.production.js`	3.78 kB
`./dist/utils.js`	247 B
`./dist/vanilla/utils.js`	6.1 kB

_{compressed-size-action}

github-actions · 2024-12-11T11:52:13Z

Preview in LiveCodes

Latest commit: 897e005
Last updated: Dec 23, 2024 3:19am (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/9LNKW8YBL

See documentations for usage instructions.

src/vanilla/store.ts

dai-shi · 2024-12-11T12:19:29Z

/ecosystem-ci run

github-actions · 2024-12-11T12:21:17Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

dai-shi · 2024-12-11T12:29:51Z

@arjunvegda Let's add jotai-devtools to https://github.com/jotaijs/jotai-ecosystem-ci ! Can you open a PR there?

dai-shi · 2024-12-11T23:09:04Z

Separately, I think createPending should be part of deriveStore.

If necessary, I generally want to make functions as pure as reasonably possible.

(edit: I misunderstood the question.)

dai-shi · 2024-12-11T23:29:11Z

/ecosystem-ci run

github-actions · 2024-12-11T23:32:03Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "FAIL",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

dai-shi · 2024-12-11T23:34:23Z

"jotai-devtools": "FAIL",

Yes, it's expected. Cool.

pkg-pr-new · 2024-12-16T14:33:41Z

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2852

commit: 897e005

dai-shi · 2024-12-19T01:15:45Z

/ecosystem-ci run

github-actions · 2024-12-19T01:17:57Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "FAIL",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

src/vanilla/store.ts

dai-shi · 2024-12-19T01:29:10Z

"jotai-devtools": "FAIL",

Hmm, it's unexpected.

dai-shi · 2024-12-19T01:32:08Z

@arjunvegda Can you help here? My expectation is this is compatible behavior-wise, but there might be some cases to break.

dai-shi · 2024-12-19T02:14:44Z

/ecosystem-ci run

github-actions · 2024-12-19T02:16:55Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

dai-shi · 2024-12-19T02:19:55Z

🎉 Thanks @arjunvegda! I'm planning to release this next week.

src/vanilla/store.ts

dai-shi · 2024-12-19T03:19:20Z

/ecosystem-ci run

github-actions · 2024-12-19T03:21:43Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

src/vanilla/store.ts

dai-shi · 2024-12-23T03:24:50Z

/ecosystem-ci run

github-actions · 2024-12-23T03:27:09Z

Ecosystem CI Output

---- Jotai Ecosystem CI Results ----
{
  "bunshi": "PASS",
  "jotai-devtools": "PASS",
  "jotai-effect": "PASS",
  "jotai-scope": "PASS"
}

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [jotai](https://github.com/pmndrs/jotai) | dependencies | minor | [`2.9.3` -> `2.11.0`](https://renovatebot.com/diffs/npm/jotai/2.9.3/2.11.0) | --- ### Release Notes <details> <summary>pmndrs/jotai (jotai)</summary> ### [`v2.11.0`](https://github.com/pmndrs/jotai/releases/tag/v2.11.0) [Compare Source](pmndrs/jotai@v2.10.4...v2.11.0) There are no public API changes, but some internal behaviors have been improved. Now, atom updates are batched in a single write, which might provide a performance benefit in certain edge cases. This feature has been requested actually for a long time, and it's finally implemented. See also [#2782](pmndrs/jotai#2782). #### What's Changed - refactor(store): rename pending to batch by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2868 - lazy recomputeDependents by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2827 - fix(store): robust flush batch by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2871 - fix(store): refactor batch priority by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2875 - feat: dev store with unstable_derive by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2852 #### New Contributors - [@rainagalbiati-turngate](https://github.com/rainagalbiati-turngate) made their first contribution in pmndrs/jotai#2882 - [@leweyse](https://github.com/leweyse) made their first contribution in pmndrs/jotai#2883 **Full Changelog**: pmndrs/jotai@v2.10.4...v2.11.0 ### [`v2.10.4`](https://github.com/pmndrs/jotai/releases/tag/v2.10.4) [Compare Source](pmndrs/jotai@v2.10.3...v2.10.4) A minor improvement for some edge cases. (For more information, see [#2789](pmndrs/jotai#2789).) #### What's Changed - fix(store): do not recompute unmounted atoms eagerly by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2849 #### New Contributors - [@rmillio](https://github.com/rmillio) made their first contribution in pmndrs/jotai#2832 - [@sukvvon](https://github.com/sukvvon) made their first contribution in pmndrs/jotai#2851 **Full Changelog**: pmndrs/jotai@v2.10.3...v2.10.4 ### [`v2.10.3`](https://github.com/pmndrs/jotai/releases/tag/v2.10.3) [Compare Source](pmndrs/jotai@v2.10.2...v2.10.3) This fixes various edge cases. Huge thanks to [@dmaskasky](https://github.com/dmaskasky) ! 🎉 #### What's Changed - fix: flushPending in async write by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2804 - fix: flush pending finally everywhere by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2818 - fix: rethrow falsy errors thrown in flushPending by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2820 - fix: setAtom uses stale pending on atom unmount by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2811 - fix: onMount setSelf does not notify listeners by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2815 - refactor(core): Use iterative approach in recompute dependents by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2821 - refactor(store): prefer epoch number comparisons to indicate value change by [@dmaskasky](https://github.com/dmaskasky) in pmndrs/jotai#2828 **Full Changelog**: pmndrs/jotai@v2.10.2...v2.10.3 ### [`v2.10.2`](https://github.com/pmndrs/jotai/releases/tag/v2.10.2) [Compare Source](pmndrs/jotai@v2.10.1...v2.10.2) Fixed some jotai/utils for a regression in v2.10.0. #### What's Changed - fix(unstable_derive): trap atom methods by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2741 - Throw error on `useAtom(undefined)` or `useAtom(null)` by [@kevinschaich](https://github.com/kevinschaich) in pmndrs/jotai#2778 - fix(utils): make 'loadable' update immediate after resolve by [@e7h4n](https://github.com/e7h4n) in pmndrs/jotai#2790 - fix(utils): make 'unwrap' update immediate after resolve by [@organize](https://github.com/organize) in pmndrs/jotai#2794 #### New Contributors - [@niklasbec](https://github.com/niklasbec) made their first contribution in pmndrs/jotai#2773 - [@romain-trotard](https://github.com/romain-trotard) made their first contribution in pmndrs/jotai#2781 - [@kretajak](https://github.com/kretajak) made their first contribution in pmndrs/jotai#2786 - [@Brokyeom](https://github.com/Brokyeom) made their first contribution in pmndrs/jotai#2798 - [@ryoku4](https://github.com/ryoku4) made their first contribution in pmndrs/jotai#2802 - [@yairEO](https://github.com/yairEO) made their first contribution in pmndrs/jotai#2805 - [@kevinschaich](https://github.com/kevinschaich) made their first contribution in pmndrs/jotai#2778 - [@e7h4n](https://github.com/e7h4n) made their first contribution in pmndrs/jotai#2790 - [@organize](https://github.com/organize) made their first contribution in pmndrs/jotai#2794 **Full Changelog**: pmndrs/jotai@v2.10.1...v2.10.2 ### [`v2.10.1`](https://github.com/pmndrs/jotai/releases/tag/v2.10.1) [Compare Source](pmndrs/jotai@v2.10.0...v2.10.1) This fixes a bug in an extreme edge case. If you find this change breaks something, please report to us. #### What's Changed - fix(core): recompute dependents in edge cases by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2742 #### New Contributors - [@vangie](https://github.com/vangie) made their first contribution in pmndrs/jotai#2753 - [@ts1994tw](https://github.com/ts1994tw) made their first contribution in pmndrs/jotai#2759 - [@KagamiChan](https://github.com/KagamiChan) made their first contribution in pmndrs/jotai#2761 - [@nguyenbry](https://github.com/nguyenbry) made their first contribution in pmndrs/jotai#2762 - [@jaycho46](https://github.com/jaycho46) made their first contribution in pmndrs/jotai#2766 - [@midzdotdev](https://github.com/midzdotdev) made their first contribution in pmndrs/jotai#2767 **Full Changelog**: pmndrs/jotai@v2.10.0...v2.10.1 ### [`v2.10.0`](https://github.com/pmndrs/jotai/releases/tag/v2.10.0) [Compare Source](pmndrs/jotai@v2.9.3...v2.10.0) It comes with another significant internal change to address some edge cases. Since v2.9.0, we've been working on some internal refactors to support more edge cases and clean up the code. Users are encouraged to update to the new versions eventually, but if you're satisfied with the current situation and prefer to avoid temporary instability, you can stick with v2.8.4 for now. #### What's Changed - breaking(core): avoid continuable promise in store api by [@dai-shi](https://github.com/dai-shi) in pmndrs/jotai#2695 #### New Contributors - [@sphinxrave](https://github.com/sphinxrave) made their first contribution in pmndrs/jotai#2653 - [@mxthxngx](https://github.com/mxthxngx) made their first contribution in pmndrs/jotai#2712 - [@hoangvu12](https://github.com/hoangvu12) made their first contribution in pmndrs/jotai#2716 - [@YuHyeonWook](https://github.com/YuHyeonWook) made their first contribution in pmndrs/jotai#2734 **Full Changelog**: pmndrs/jotai@v2.9.3...v2.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/380 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>

wip: dev store with unstable_derive

ba8f00c

vercel bot deployed to Preview December 11, 2024 11:50 View deployment

dai-shi commented Dec 11, 2024

View reviewed changes

src/vanilla/store.ts Outdated Show resolved Hide resolved

dai-shi added 2 commits December 11, 2024 20:54

hack lint rule

4c70c9b

fix mounted map

1c51256

vercel bot deployed to Preview December 11, 2024 12:16 View deployment

Merge branch 'main' into chore/dev-store

2915302

vercel bot deployed to Preview December 16, 2024 14:33 View deployment

dai-shi added 2 commits December 19, 2024 09:03

Merge branch 'main' into chore/dev-store

fe0d976

implement restore atoms

20e6b37

vercel bot deployed to Preview December 19, 2024 01:09 View deployment

dai-shi changed the title ~~wip: dev store with unstable_derive~~ feat: dev store with unstable_derive Dec 19, 2024

dmaskasky reviewed Dec 19, 2024

View reviewed changes

src/vanilla/store.ts Outdated Show resolved Hide resolved

dai-shi added this to the v2.11.0 milestone Dec 19, 2024

save derivedStore.set

576a9b0

vercel bot deployed to Preview December 19, 2024 02:10 View deployment

dai-shi marked this pull request as ready for review December 19, 2024 02:20

Merge branch 'main' into chore/dev-store

229a91c

vercel bot deployed to Preview December 19, 2024 02:57 View deployment

dmaskasky reviewed Dec 19, 2024

View reviewed changes

src/vanilla/store.ts Outdated Show resolved Hide resolved

fix it

73fcd61

vercel bot deployed to Preview December 19, 2024 03:09 View deployment

dmaskasky reviewed Dec 19, 2024

View reviewed changes

src/vanilla/store.ts Show resolved Hide resolved

refactor

0116521

vercel bot deployed to Preview December 19, 2024 09:08 View deployment

Merge branch 'main' into chore/dev-store

5d920a8

vercel bot deployed to Preview December 19, 2024 11:23 View deployment

dmaskasky reviewed Dec 19, 2024

View reviewed changes

src/vanilla/store.ts Show resolved Hide resolved

Merge branch 'main' into chore/dev-store

e34ffcf

vercel bot deployed to Preview December 20, 2024 02:19 View deployment

rename

8aa1d88

vercel bot deployed to Preview December 20, 2024 05:59 View deployment

Merge branch 'main' into chore/dev-store

897e005

vercel bot deployed to Preview December 23, 2024 03:20 View deployment

dai-shi merged commit 103fb32 into main Dec 23, 2024
43 checks passed

dai-shi deleted the chore/dev-store branch December 23, 2024 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dev store with unstable_derive #2852

feat: dev store with unstable_derive #2852

dai-shi commented Dec 11, 2024

vercel bot commented Dec 11, 2024 •

edited

Loading

codesandbox-ci bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

dai-shi commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

dai-shi commented Dec 11, 2024

dai-shi commented Dec 11, 2024 •

edited

Loading

dai-shi commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

dai-shi commented Dec 11, 2024

pkg-pr-new bot commented Dec 16, 2024 •

edited

Loading

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

dai-shi commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

feat: dev store with unstable_derive #2852

feat: dev store with unstable_derive #2852

Conversation

dai-shi commented Dec 11, 2024

vercel bot commented Dec 11, 2024 • edited Loading

codesandbox-ci bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

github-actions bot commented Dec 11, 2024 • edited Loading

Preview in LiveCodes

dai-shi commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

Ecosystem CI Output

dai-shi commented Dec 11, 2024

dai-shi commented Dec 11, 2024 • edited Loading

dai-shi commented Dec 11, 2024

github-actions bot commented Dec 11, 2024

Ecosystem CI Output

dai-shi commented Dec 11, 2024

pkg-pr-new bot commented Dec 16, 2024 • edited Loading

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

Ecosystem CI Output

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

Ecosystem CI Output

dai-shi commented Dec 19, 2024

dai-shi commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

Ecosystem CI Output

dai-shi commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

Ecosystem CI Output

vercel bot commented Dec 11, 2024 •

edited

Loading

codesandbox-ci bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

dai-shi commented Dec 11, 2024 •

edited

Loading

pkg-pr-new bot commented Dec 16, 2024 •

edited

Loading