fix useprogress multi instanced and improved the related story #304
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/drei/83bo4svwy |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4cedbdf:
|
|
@joshuaellis I set back the use of DefaultLoadingManager and I just checked, nothing needs to be changed in the documentation. It should be safe and ready to merge. |
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why
fix #302
What
It seems that threejs is by default always using the DefaultLoadingManager so using a new instance of the LoadingManager won't work.
Because it uses the DefaultLoadingManager values are never reset.
I fixed it and added an offset that decrements the value for the new elements loaded when the previous loading was finished.
Before it would do :
0 -> 100% (let's say 1 -> 10 items where loaded)
Then for any new element loaded :
90% -> 100% ( 10 -> 11 items)
Now it will do the progress based on only the new element that is loading (10 - (last total loaded 10) -> 11 = 1).
I improved the story using multiple dynamic loading with Knobs to prevent errors.
The best solution would be to add a reset method to the LoadingManager in threejs.
Checklist
Demo :
https://drei-git-fork-renaudrohlinger-fix-useprogress.pmndrs.vercel.app/?path=/story/misc-useprogress--use-progress-scene-st