Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for amd #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gonpombo8
Copy link

I want to use this lib at Decentraland SDK scenes instead of the cannon.js that's not longer maintained.
But in order to do that all the external libraries need to be AMD modules. (It's the only way that will work at Decentraland, since the build only supports amd modules) https://github.com/decentraland/js-sdk-toolchain/blob/main/packages/%40dcl/amd/src/amd.ts
Currently there are bunch of scenes created by the community that uses cannon.js such as:
https://github.com/decentraland-scenes/inflatable-punch-bag, https://github.com/decentraland-scenes/tin-can-alley, https://github.com/decentraland-scenes/cannon-example-scene, https://github.com/decentraland-scenes/cannon-car-example-scene, etc.
Will be great if we can add support for amd so we can start using it.
Thanks in advance, let me know if there's something that's not clear. :)

@codynova
Copy link
Member

Wouldn't most of the rollup plugins for ESM and CJS also need to be used in the AMD build?

@gonpombo8
Copy link
Author

Wouldn't most of the rollup plugins for ESM and CJS also need to be used in the AMD build?

Sorry i didn't get it. What do u mean ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants