Add chapter on Process Sets and Groups #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjelmn Could you please review this? I have attached the pdf form of the new chapter to make for easier reading. |
hppritcha
reviewed
Jan 14, 2019
| \label{chap:api_sets_groups} | ||
|
|
||
| \ac{PMIx} supports two slightly related, but functionally different concepts known as \emph{process sets} and \emph{process groups}. This chapter describes the two definitions and how they are utilized, along with their corresponding \acp{API}. | ||
|
|
There was a problem hiding this comment.
I'd say either
This chapter describes these two concepts...
Or
This chapter defines these two concepts...
There was a problem hiding this comment.
Thanks @hppritcha - I like your second option and will go with it!
|
@rhc54 This looks pretty good. The clarification about difference between sets and groups is useful. I had one minor comment for the opening paragraph. |
Describe the overall concepts and how these two definitions differ. Define APIs and attributes Signed-off-by: Ralph Castain <[email protected]> dd Signed-off-by: Ralph Castain <[email protected]>
Thanks to suggestion by @hppritcha Signed-off-by: Ralph Castain <[email protected]>
|
Per @hppritcha, this is good to go! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the overall concepts and how these two definitions differ.
Define APIs and attributes
Signed-off-by: Ralph Castain [email protected]
dd
Signed-off-by: Ralph Castain [email protected]