run_qemu.sh: restore ability to build without ndctl #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes commit 1a2a679 ("run_qemu.sh: fail immediately when $ndctl is invalid") My bad, I didn't realize `readlink -f $does_not_exist` prints "$does_not_exit", I assumed it prints nothing and I did not test enough combinations. So, that previous commit made it way too hard to disable the ndctl build: you must pass `--no-ndctl-build` _and_ have a valid `~/git/ndctl`?! This makes no sense. Fix the logic so either a blank `ndctl=`, or `--no-ndctl-build` is each enough to disable the ndctl build. Signed-off-by: Marc Herbert <[email protected]>
|
I just discovered that readlink -f notfound/notfound # empty
mkdir found
readlink -f found/notfound
/home/me/found/notfound # notfound does not exist, printed anyway!! |
|
#97 is enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commit 1a2a679 ("run_qemu.sh: fail immediately when $ndctl is invalid")
My bad, I didn't realize
readlink -f $does_not_existprints "$does_not_exit", I assumed it prints nothing and I did not test enough combinations. So, that previous commit made it way too hard to disable the ndctl build: you must pass--no-ndctl-buildand have a valid~/git/ndctl?! This makes no sense.Fix the logic so either a blank
ndctl=, or--no-ndctl-buildis each enough to disable the ndctl build.