Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

doc: separate receive CQ & rpma_mr_advise() #1216

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

janekmi
Copy link

@janekmi janekmi commented Aug 24, 2021

Ref: #1080 #1220


This change is Reviewable

@janekmi janekmi marked this pull request as draft August 24, 2021 21:31
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@yangx-jy yangx-jy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

a discussion (no related file):
:lgtm:


@janekmi
Copy link
Author

janekmi commented Sep 14, 2021

Have to consider also the newest update #1220

@janekmi janekmi force-pushed the doc-separate-cq branch 2 times, most recently from 870830d to b6d2604 Compare September 17, 2021 15:10
@janekmi janekmi marked this pull request as ready for review September 17, 2021 15:16
Copy link
Author

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @yangx-jy)

a discussion (no related file):

Previously, yangx-jy (Xiao Yang) wrote…

:lgtm:

Done. ;-)


a discussion (no related file):
Preview: https://janekmi.github.io/rpma/manpages/master/librpma.7.html


@janekmi janekmi changed the title doc: separate receive CQ doc: separate receive CQ & rpma_mr_advise() Sep 17, 2021
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yangx-jy)

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yangx-jy)

Copy link
Member

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yangx-jy)

a discussion (no related file):

Previously, janekmi (Jan Michalski) wrote…

Done. ;-)

:lgtm: :-)


@ldorau ldorau merged commit a24ba10 into pmem:gh-pages Sep 22, 2021
@janekmi janekmi deleted the doc-separate-cq branch December 31, 2021 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants