-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: add coverage build #5830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5830 +/- ##
===========================================
+ Coverage 0 70.99% +70.99%
===========================================
Files 0 131 +131
Lines 0 19175 +19175
Branches 0 3193 +3193
===========================================
+ Hits 0 13614 +13614
- Misses 0 5561 +5561 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)
.github/workflows/ubuntu.yml
line 28 at r2 (raw file):
strategy: matrix: TEST_BUILD: ['debug', 'nondebug']
There is redundant space at the end of the line. Please remove.
utils/create-testconfig.sh
line 49 at r2 (raw file):
# static values for both Bash and Python KEEP_GOING=n
I think this change has to be considered in the wider context. e.g. this script is also used for Valgrind and long tests in which cases we might actually prefer to keep KEEP_GOING=y
. I think it eventually will become a regular parameter for this script like OUTPUT_DIR with some reasonable default.
But for the sake of this change, it is unnecessary to change this behaviour as well. We have established off-line that COVERAGE=1
builds do not benefit from changing this setting anyway.
e32bc96
to
189a2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @janekmi)
.github/workflows/ubuntu.yml
line 28 at r2 (raw file):
Previously, janekmi (Jan Michalski) wrote…
There is redundant space at the end of the line. Please remove.
Done.
utils/create-testconfig.sh
line 49 at r2 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I think this change has to be considered in the wider context. e.g. this script is also used for Valgrind and long tests in which cases we might actually prefer to keep
KEEP_GOING=y
. I think it eventually will become a regular parameter for this script like OUTPUT_DIR with some reasonable default.But for the sake of this change, it is unnecessary to change this behaviour as well. We have established off-line that
COVERAGE=1
builds do not benefit from changing this setting anyway.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
This change is