Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: rationalize the use of NDCTL_ENABLE in testing (no-pmem) #5827

Merged
merged 3 commits into from
Jul 27, 2023
Merged

common: rationalize the use of NDCTL_ENABLE in testing (no-pmem) #5827

merged 3 commits into from
Jul 27, 2023

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Jul 26, 2023 •
edited by pbalcer
Loading

This change is Reviewable

@janekmi janekmi added the sprint goal This pull request is part of the ongoing sprint label Jul 26, 2023
@janekmi janekmi added this to the 2.0.0 milestone Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #5827 (58d08dc) into master (514c7d8) will decrease coverage by 0.02%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5827      +/-   ##
==========================================
- Coverage   71.01%   70.99%   -0.02%     
==========================================
  Files         131      131              
  Lines       19175    19175              
  Branches     3193     3192       -1     
==========================================
- Hits        13617    13614       -3     
- Misses       5558     5561       +3

osalyk
osalyk approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@janekmi janekmi merged commit ab540ef into pmem:master Jul 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalyk osalyk osalyk approved these changes

Assignees
No one assigned
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@janekmi @osalyk