[java] Support Java 23 #5112
Merged
[java] Support Java 23 #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotuyod
reviewed
Jul 11, 2024
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTVariableId.java
Outdated
Show resolved
Hide resolved
oowekyala
reviewed
Jul 11, 2024
.../src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/SymbolTableResolver.java
Outdated
Show resolved
Hide resolved
.../src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstSymbolMakerVisitor.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
adangel
commented
Jul 22, 2024
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTImportDeclaration.java
Show resolved
Hide resolved
|
Also, 24-ea is available to GitHub actions, which we use over at Apache Commons as we do 23-ea, but all these fail due to the dependency on ASM 9.6. |
adangel
force-pushed
the
issue-5062-support-java-23
branch
from
8353ccd to
3cb4c4a
Compare
This is now possible, since java 21 preview is gone.
... and Instance Main Methods" (JEP 477) - language feature is renamed - update symbol table resolver
- new JModuleSymbol - UnnecessaryImportRule also supports module imports - module-info.class can be loaded by ClasspathClassLoader - Support annotations on modules - Verify that exported packages are loaded
Allow to use primitive types in patterns, instanceof, and switch. This is a Java 23 Preview feature. See JEP 455.
JEP 477: Implicitly Declared Classes and Instance Main Methods (Third Preview)
Import by default module java.base and java.io.IO.*
Reuse the classloader for auxclasspath instead of creating a new one for every single rule test case.
adangel
force-pushed
the
issue-5062-support-java-23
branch
from
3cb4c4a to
f33e75c
Compare
Also add some @SInCE tags to new API methods
adangel
force-pushed
the
issue-5062-support-java-23
branch
from
f33e75c to
21d499d
Compare
oowekyala
reviewed
Aug 1, 2024
.../src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/SymbolTableResolver.java
Outdated
Show resolved
Hide resolved
pmd-core/src/main/java/net/sourceforge/pmd/internal/util/ClasspathClassLoader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Clément Fournier <[email protected]>
oowekyala
reviewed
Nov 18, 2024
| @Override | ||
| public @Nullable JTypeMirror resolveFirst(String simpleName) { | ||
| for (String module : moduleNames) { | ||
| JModuleSymbol moduleSymbol = symbolResolver.resolveModule(module); |
There was a problem hiding this comment.
This should be cached in the name resolver, otherwise it will perform a classloader lookup and parse the module file for every name that is requested (which is probably all the type identifiers in the compilation unit).
| } | ||
|
|
||
| for (String packageName : moduleSymbol.getExportedPackages()) { | ||
| JClassSymbol sym = symbolResolver.resolveClassFromCanonicalName(packageName + "." + simpleName); |
There was a problem hiding this comment.
This should resolve from binary name instead of canonical name, otherwise it will try every package segment. But we know that these segments are packages and not outer classes. This is different from type import on demand, because these can import inner types too.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This is ready now.
I pushed the branch is directly to our main repo on github: https://github.com/pmd/pmd/tree/issue-5062-support-java-23.
Java 23 is GA in September, which means it would be great, if we could finish this latest in August, so that in lands in PMD 7.5.0 to be released end of August.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)