Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new PMD 7 CLI interface #114

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Conversation

adangel
Copy link
Member

@adangel adangel commented Oct 7, 2022

This adds support for thew new PicoCLI based command line. The actual parameters didn't change, but the base command:

  • PMD 6: bin/run.sh pmd
  • PMD 7: bin/pmd check

@adangel adangel added this to the next milestone Oct 7, 2022
@adangel adangel added the enhancement New feature or request label Oct 7, 2022
@adangel
Copy link
Member Author

adangel commented Oct 7, 2022

Ok, one failing integration test. But that's expected: The test test_build(IntegrationTestPmdReportBuilder) tests creating a regression report for master vs. pmd/7.0.x. It already uses the new command to call pmd7:

/home/runner/work/pmd-regression-tester/pmd-regression-tester/target/pmd-bin-7.0.0-SNAPSHOT-origin_pmd_7.0.x-11763cdc604a8288b0b079f6707ce8eebb53747d/bin/pmd analyze -d target/repositories/checkstyle ...

And therefore fails:

  D, [2022-10-07T10:02:29.225724 #2844] DEBUG -- : status: pid 3923 exit 127
  D, [2022-10-07T10:02:29.225762 #2844] DEBUG -- : stdout: 
  D, [2022-10-07T10:02:29.225787 #2844] DEBUG -- : stderr: sh: 1: /home/runner/work/pmd-regression-tester/pmd-regression-tester/target/pmd-bin-7.0.0-SNAPSHOT-origin_pmd_7.0.x-11763cdc604a8288b0b079f6707ce8eebb53747d/bin/pmd: not found

So, this integration test will be good, once pmd/pmd#4059 is merged.

Don't check the version. That way, the regression
tester is forward compatible.
@adangel adangel merged commit 3b26e7f into pmd:master Oct 16, 2022
@adangel adangel deleted the update-new-pmd7-cli branch October 16, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant