-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tab width char handling #45
Conversation
With pmd/pmd#2656 tab characters are now handled with column with of 1. That means, the position that PMD's parser reports uses this with. The display of the tab character might be different in the code are of the designer (and in any other text editor).
@oowekyala But I've checked the changed in the pmd-designer, and I think, there is another way:
I'm proposing to do the 6.27.0 release of the designer off of this branch "6.27-dev" and merge that branch then afterwards into master for the next designer release, where we can use directly pmd-core 6.27.0 (instead of snapshot). That way, we would have the "normal" release order: pmd-designer -> pmd. What do you think? |
This sounds simpler, I'm all for it. So this release of the designer will be versioned 6.27.0, correct? And then the development version will be bumped to depend on pmd-core 6.27.0, and be versioned 6.28.0-snapshot? |
Yes, exactly |
I'm not sure why we need to merge it on a separate branch though. Is it because of CI? If it's simpler for you then do as you please. I'm just trying to understand BTW whether you intend to merge or close this PR it's probably better if you do it. I'm removing my assignment |
I've created the branch 6.27-dev before your commit e0f23e1 . the branch can be considered as a pull request not against master but against 3290177 - the problem is, that the development for the next version is already ongoing on master in pmd-designer.... Once the branch 6.27-dev is merged back into master, we can close this PR as done - no need to merge it, as the code changes are then already included. |
With pmd/pmd#2656 tab characters are now handled with column
with of 1. That means, the position that PMD's parser reports
uses this with. The display of the tab character might be different
in the code are of the designer (and in any other text editor).