Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Fixed the problem on displaying icons. #231

Closed
wants to merge 1 commit into from

Conversation

xiaokangwang
Copy link

Original one lead to a misbehavior on at least Chrome(Linux) and Firefox(Linux).

This problem is probable caused by forget to add 'glyphicon' to class for li.

The example on the official bootstrap site also have 'glyphicon' added to the class.

Before:
err3

After:
err2

Original one lead to a misbehavior on at least Chrome(Linux) and Firefox(Linux).

This problem is probable caused by forget to add 'glyphicon' to class for li.

The example on the [official bootstrap](http://getbootstrap.com/components/#glyphicons) site also have 'glyphicon' added to the class.
@roman-yagodin
Copy link
Contributor

I think c77431d is fixing this exactly the same way. Sorry, @xiaokangwang - I should've search in existing pull requests first before creating another ones...

@groundh0g groundh0g added this to the v 0.5.0 milestone Apr 5, 2015
@groundh0g groundh0g self-assigned this Apr 5, 2015
@groundh0g
Copy link
Collaborator

@roman-yagodin's right. Exact duplicate of #234, which has already been merged. Thanks for contribution, though!

@groundh0g groundh0g closed this May 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants