Comments form intense debate #187
Conversation
Intense Debate comments provider: Setting the default behavior to had the comments form below the post instead of adding a link with the comments count
|
@pierre-jean: thanks for submitting the pull request! Agree with the confusing display of the link, please see my comments. Thanks. |
| @@ -3,4 +3,5 @@ var idcomments_acct = '{{ site.JB.comments.intensedebate.account }}'; | |||
| var idcomments_post_id; | |||
| var idcomments_post_url; | |||
| </script> | |||
| <script type="text/javascript" src="http://www.intensedebate.com/js/genericLinkWrapperV2.js"></script> | |||
| <span id="IDCommentsPostTitle" style="display:none"></span> | |||
There was a problem hiding this comment.
inline CSS is not preferred. Move it into stylesheet.
There was a problem hiding this comment.
Actually, I think I can totally remove the span "IDCommentsPostTitle", and just leave the script.
I added it because it was the code suggested by intensedebate website, but removing it has no effect, the comments section is still at the same place, and the title isn't displayed in both cases.
Do you agree?
|
@marshallshen Thanks for your comment, I preferred removing the span than adding some CSS for a element unvisible by default. Please see comment on the diff. |
|
Looks like a low-risk edit. @marshallshen's concern was addressed by @pierre-jean. Merging. |
Comments form intense debate
By default, the comment provider of JB for intensedebate display a links in the form "comments (0)".
The link itself has no effect by default, so it's kind of confusing for beginners who just set up the comments provider on the config and are hoping for a comments section.
With this commit, the comment form is displayed at the bottom of the post.