Add baidu in analytics provider, add tip for enabling analytics plugin #158
Conversation
|
Related issue #84. site.safe may be obsoleted. |
| @@ -95,6 +95,7 @@ JB : | |||
| colorscheme: light | |||
|
|
|||
| # Settings for analytics helper | |||
| # Set 'site.safe' to true to enable analytics plugin | |||
There was a problem hiding this comment.
@themez we've moved away from using site.safe to decide if the site is in production mode. I'm killing this line and merging the rest.
There was a problem hiding this comment.
@themez, crap. I can't edit inline. I will have to resubmit this using my account, or you can make the tweak on your end and I'll merge. Lemme know.
There was a problem hiding this comment.
@themez, double crap. This now has merge conflicts. Will have to create new PR. If you don't have time or desire, I'll handle it. Thanks for contribution!
There was a problem hiding this comment.
Hi ground0g, I've already deleted my fork repo, cannot make a new pr now.. It would be good if you can fix it with your account.
There was a problem hiding this comment.
Will do. Thanks for the contribution! Sorry it's taken so long to review.
|
Isolated. New analytics provider. Low risk. BUT ... Cannot merge now. See line-item comments. |
|
From @themez:
Will do. Thanks for the contribution! Sorry it's taken so long to review. |
|
Made edits by hand in local repo. Pushing this weekend. |
…an account to test, but this is isolated code and the risk to break existing analytics modules is low.
analytics only works when
safeis true, it's better to put a tip there.