Skip to content
This repository has been archived by the owner on Nov 30, 2024. It is now read-only.

Google universal tracking #135

Merged

Conversation

jousby
Copy link

@jousby jousby commented Mar 21, 2013

Google Analytics has two options for tracking websites now. The legacy system which is now called 'classic' and the new system called 'universal tracking' which is in beta. This pull request adds support for the new universal tracking script and adds 'google_classic' and 'google_universal' as options in the providers section of the config file.

@bzz
Copy link

bzz commented Nov 4, 2013

Thank you for contributing!
+1 for merging this one as this still keeps classic code and adds new universal one.
Is there anything to be done to merge\close it?

@marshallshen
Copy link
Collaborator

@jousby , thanks for the PR!

marshallshen added a commit that referenced this pull request Dec 16, 2013
@marshallshen marshallshen merged commit 0980641 into plusjade:jb-development Dec 16, 2013
@sapzildj
Copy link

sapzildj commented Aug 7, 2015

+1

@groundh0g groundh0g mentioned this pull request Aug 9, 2015
@groundh0g
Copy link
Collaborator

This was a PR against the jb-development branch, which ideally would be host to our features until merging into master. Unfortunately, the merge didn't have the desired effect.

Looks like the analytics stub is also in the master branch (as googleUA via PR #228), but not referenced in the analytics include or in the _config.yml. Should be a trivial matter to incorporate the edits from this PR along with #228.

I didn't realize the plumbing was disconnected earlier. Thanks for bringing attention to this.

Since both source PRs are closed, I created issue #282 to track.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants