Implementation of social sharing buttons into Jekyll Bootstrap #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: _includes/JB/sharing new file: _includes/JB/sharing-providers/facebook new file: _includes/JB/sharing-providers/global new file: _includes/JB/sharing-providers/googleplus new file: _includes/JB/sharing-providers/hn new file: _includes/JB/sharing-providers/linkedin new file: _includes/JB/sharing-providers/twitter modified: _includes/themes/twitter/post.html
|
This request must land! I've looked around for sharing plugins but this way seems to be right. |
|
why isn't this pull request merged, it looks terrific! |
|
is this available as a plugin? |
|
@musketyr because people might want to use share links instead of javascript trackers? |
|
Looks good. Merge conflicts now. Bumping to next release and adding a reference to related issue #90. Sorry this has taken so long to review. Thanks for the contribution! |
kazuhito-m
added a commit
to kazuhito-m/kazuhito-m.github.io
that referenced
this pull request
Sep 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details and explanations can be found in this blog post.