Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to tgw and vpc attachments for security group referencing #378

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

lorengordon
Copy link
Member

No description provided.

@lorengordon lorengordon requested a review from a team September 30, 2024 14:02
Copy link

@yiltis-p3 yiltis-p3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved!

@lorengordon
Copy link
Member Author

Results of make test:

❯ !20041
make terraform/pytest PYTEST_ARGS="-v --nomock"
[bootstrap]: Using external tardigrade-ci, skipping auto-init
[pytest//home/x/git/repos/tardigrade-ci/tests/terraform_pytest] Starting Python tests found under the directory "/home/x/git/repos/tardigrade-ci/tests/terraform_pytest"
pytest /home/x/git/repos/tardigrade-ci/tests/terraform_pytest -v --nomock
================= test session starts =================
platform linux -- Python 3.8.18, pytest-8.2.2, pluggy-1.5.0 -- /home/x/.pyenv/versions/3.8.18/bin/python3.8
cachedir: .pytest_cache
rootdir: /home/x/git/repos
collected 4 items

../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[cross-account-vpc-attachment] PASSED                                                                                                  [ 25%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[cross-region-peering-attachment] PASSED                                                                                               [ 50%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[cross-account-vpc-attachment-auto-acceptor] PASSED                                                                                    [ 75%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[tgw] PASSED                                                                                                                           [100%]

=========== 4 passed in 2042.80s (0:34:02) ============
[pytest//home/x/git/repos/tardigrade-ci/tests/terraform_pytest]: Tests executed!

@lorengordon lorengordon merged commit 03b7393 into plus3it:master Sep 30, 2024
4 of 5 checks passed
@lorengordon lorengordon deleted the feat/sg-references branch September 30, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants