Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standards control feature added #114

Merged
merged 2 commits into from
Jun 1, 2023
Merged

standards control feature added #114

merged 2 commits into from
Jun 1, 2023

Conversation

johnricords
Copy link
Contributor

No description provided.

lorengordon
lorengordon reviewed May 25, 2023
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@johnricords johnricords force-pushed the newFeatures branch 3 times, most recently from 23d3bcd to 71d9fd6 Compare May 25, 2023 17:39
lorengordon
lorengordon reviewed May 25, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
lorengordon
lorengordon reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question on the depends_on list...

main.tf Show resolved Hide resolved
@lorengordon
Copy link
Member

Result of make test:

AWS_DEFAULT_REGION=us-east-1 TF_VAR_member_email=...... make test PYTEST_ARGS="-v --nomock"
[bootstrap]: Using external tardigrade-ci, skipping auto-init
[pytest//home/loren/git/repos/tardigrade-ci/tests/terraform_pytest] Starting Python tests found under the directory "/home/loren/git/repos/tardigrade-ci/tests/terraform_pytest"
pytest /home/loren/git/repos/tardigrade-ci/tests/terraform_pytest -v --nomock
============================================= test session starts ==============================================
platform linux -- Python 3.8.10, pytest-7.2.2, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/loren/git/repos
plugins: mock-3.6.1, cov-2.12.1, travis-fold-1.3.0
collected 2 items

../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[securityhub_cross_account] PASSED                                                                                                                                                            [ 50%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[securityhub_same_account] PASSED                                                                                                                                                             [100%]

========================================= 2 passed in 81.63s (0:01:21) =========================================
[pytest//home/loren/git/repos/tardigrade-ci/tests/terraform_pytest]: Tests executed!

@johnricords johnricords merged commit df76978 into plus3it:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorengordon lorengordon lorengordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnricords @lorengordon