Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): run the container as non-root #874

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

davidspek
Copy link
Contributor

UID and GID are > 10000 to conform with best practices. See https://avd.aquasec.com/misconfig/kubernetes/general/avd-ksv-0021/ and https://avd.aquasec.com/misconfig/ksv020

Summary

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@davidspek davidspek added the enhancement New feature or request label Jan 26, 2023
@stoat-app
Copy link

stoat-app bot commented Jan 26, 2023

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit 68fe919
rtc-coverage Visit 68fe919
core-coverage Visit 68fe919
cron-coverage Visit 68fe919
email-coverage Visit 68fe919
worker-coverage Visit 68fe919
api-test-results Visit 68fe919
graphql-coverage Visit 68fe919
rtc-test-results Visit 68fe919
core-test-results Visit 68fe919
cron-test-results Visit 68fe919
email-test-results Visit 68fe919
worker-test-results Visit 68fe919
graphql-test-results Visit 68fe919

Job Runtime

job runtime chart

debug

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold off on this until after product hunt since if it could go wrong it could bring the site down or major parts of plural functionality

@davidspek
Copy link
Contributor Author

@michaeljguarino I've deployed the images and they all run as expected without any crashes.

@davidspek davidspek marked this pull request as ready for review January 26, 2023 13:53
@davidspek
Copy link
Contributor Author

We'll need to configure different ports for the services for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants