Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault private ingress #437

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Vault private ingress #437

wants to merge 6 commits into from

Conversation

BogdanAntoniu78
Copy link
Contributor

Summary

Changes on this PR:

  • Private ingress added for Vault deployment
  • Runbooks
  • CPU/Memory requests and limits set

Test Plan

  • Runbooks corectly displayed in Console
  • Pods are starting with new requests and limits
  • If exposePrivate flag is set to true, Vault UI is available only when using VPN connection to EKS cluster

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

davidspek and others added 2 commits November 9, 2022 13:16
Signed-off-by: David van der Spek <[email protected]>
@@ -43,7 +43,11 @@ vault:
cert-manager.io/cluster-issuer: letsencrypt-prod
nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
nginx.ingress.kubernetes.io/use-regex: "true"
{{- if not .Values.exposePrivate }}
ingressClassName: nginx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these values should actually be moved down to values.yaml since the current setup prevents reconfiguration. Really we should have nginx as the default there then overwrite with:

{{ if .Values.exposePrivate }}
ingressClassName: internal-nginx
{{ end }}

in values.yaml.tpl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I moved the values to values.yaml.tpl. Ihad to leave also the else statement, as otherwise the className gets undefined.

- moved from tpl to value.yaml ingress values
- bumped the chart version
Changed the logic on exposePrivate boolean value
@michaeljguarino
Copy link
Member

It looks like this does have a merge conflict to resolve

@BogdanAntoniu78
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants