perf: Use Set to optimize performance

plumelo · Jun 4, 2021 · b402687 · b402687
1 parent 95cc2b5
commit b402687
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -125,17 +125,17 @@ export default (options: Options = {}): Plugin => {
 
       const ids: string[] = [];
       for (const module of Object.keys(chunk.modules)) {
-        const traversed: string[] = [];
+        const traversed: Set<string> = new Set();
         let current = [module];
         do {
           const imports: string[] = [];
           for (const id of current) {
-            if (traversed.includes(id)) continue;
+            if (traversed.has(id)) continue;
             if (loaders.isSupported(id)) {
               if (isIncluded(id)) imports.push(id);
               continue;
             }
-            traversed.push(id);
+            traversed.add(id);
             const i = this.getModuleInfo(id);
             i && imports.push(...i.importedIds);
           }
@@ -217,17 +217,17 @@ export default (options: Options = {}): Plugin => {
         const ids: string[] = [];
 
         for (const module of Object.keys(chunk.modules)) {
-          const traversed: string[] = [];
+          const traversed: Set<string> = new Set();
           let current = [module];
           do {
             const imports: string[] = [];
             for (const id of current) {
-              if (traversed.includes(id)) continue;
+              if (traversed.has(id)) continue;
               if (loaders.isSupported(id)) {
                 if (isIncluded(id)) imports.push(id);
                 continue;
               }
-              traversed.push(id);
+              traversed.add(id);
               const i = this.getModuleInfo(id);
               i && imports.push(...i.importedIds);
             }