Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Container): deactivate domtab that no longer works and stop offer… #741

Conversation

stonebuzz
Copy link
Contributor

Since GLPI 10

Ticket Solution tab no longer exist
Problem Solution tab no longer exist
Change Analysis / Solution / Plans no longer exist

So, deactivate related container (with type Insertion in the form of a specific tab (before save button)) and remove the ability to create containers on these tabs (tabs on Entity are maintained as they are still functional))

Release note should mention this :

Adding a container (with type Insertion in the form of a specific tab (before save button)) to the following tabs is no longer possible (as it no longer works since version 10)

  • Change -> analysis
  • Change -> plans
  • Change -> solution
  • Ticket -> solution
  • Problem -> solution

All related container have been deactivated

For the Solution, it is now possible to add a block on ITILSolution, only for the "Insertion in the form (before save button)" type.

IMPORTANT
no migration proposed from the old type to the new one,
as it hasn't worked for a while, I don't suppose anyone has added a block
and required lot of work

Fix :
#737
#407
#599
#456

@Apashh
Copy link

Apashh commented Jan 3, 2024

Hello,

If i understand, now its not possible to add a field on solution ? Like this ?
image

A solution have been created : #612
But not work

Can you explain your branch and your code ? What is the solution to use a field before send solution ?

Thanks !

@stonebuzz
Copy link
Contributor Author

For the Solution, it is now possible to add a block on ITILSolution, only for the "Insertion in the form (before save button)" type.

For the Solution, it is now possible to add a block on ITILSolution, only for the "Insertion in the form (before save button)" type.

@Apashh
Copy link

Apashh commented Jan 8, 2024

For the Solution, it is now possible to add a block on ITILSolution, only for the "Insertion in the form (before save button)" type.

For the Solution, it is now possible to add a block on ITILSolution, only for the "Insertion in the form (before save button)" type.

Okay its not a good solution, it will be better to add field directely on solution reply.. So shame...

@stonebuzz
Copy link
Contributor Author

Okay its not a good solution, it will be better to add field directely on solution reply.. So shame...

Solution approval is not the same object (in the php sense) as Solution

It is not possible to add a field here

The purpose of this PR is simply to restore GLPI 9.5 behavior.

@cedric-anne cedric-anne requested review from Rom1-B and AdrienClairembault and removed request for cedric-anne February 21, 2024 08:08
inc/container.class.php Outdated Show resolved Hide resolved
@Rom1-B Rom1-B self-requested a review February 21, 2024 09:47
@AdrienClairembault AdrienClairembault merged commit 5024bf1 into pluginsGLPI:main Feb 21, 2024
3 checks passed
This was referenced Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants