Fix group user import

[cconard96]

Try to fix certain cases of imports such as a Group import that includes a group member field.
Commit 6974858 had broken this type of import because effectiveAddOrUpdate would receive an itemtype and items_id value which were not valid search options, but were still required for the import to work.

This patch seems to resolve this particular issue although I don't know if it will cause other issues.

[cedric-anne]

@cconard96 Can this be fixed by #302 ?

[cconard96]

@kabassanov and I saw that PR and it did not seem to fix the issue they were having.

[stonebuzz]

@cconard96 does not work for me

My CSV file

user_name; group_name
user1 ; group1

Error :

[2022-09-09 08:07:25] glpisqllog.ERROR: DBmysql::query() in /home/dev/GLPI/10.0-bugfixes/src/DBmysql.php line 370
  *** MySQL query error:
  SQL: INSERT INTO `glpi_users` (`name`, `groups_id`, `entities_id`, `authtype`, `auths_id`, `is_active`, `is_deleted`, `profiles_id`, `date_creation`, `date_mod`) VALUES ('user1', 'group1', '0', '1', '0', '1', '0', '0', '2022-09-09 08:07:25', '2022-09-09 08:07:25')
  Error: Incorrect integer value: 'group1' for column 'groups_id' at row 1
  Backtrace :
  src/DBmysql.php:1312                               
  src/CommonDBTM.php:716                             DBmysql->insert()
  src/CommonDBTM.php:1316                            CommonDBTM->addToDB()
  ...injection/inc/commoninjectionlib.class.php:1549 CommonDBTM->add()
  ...injection/inc/commoninjectionlib.class.php:1453 PluginDatainjectionCommonInjectionLib->effectiveAddOrUpdate()
  ...s/datainjection/inc/userinjection.class.php:121 PluginDatainjectionCommonInjectionLib->processAddOrUpdate()
  plugins/datainjection/inc/engine.class.php:147     PluginDatainjectionUserInjection->addOrUpdateObject()
  ...datainjection/inc/clientinjection.class.php:267 PluginDatainjectionEngine->injectLine()
  ...datainjection/inc/clientinjection.class.php:219 PluginDatainjectionClientInjection::processInjection()
  ...datainjection/front/clientinjection.form.php:42 PluginDatainjectionClientInjection::showInjectionForm()
  {"user":"2@stanislas-XPS-13-9343"} 

[stonebuzz]

group1 is well added to GLPI, but datainjection does not keep track of the ID

[kabassanov]

You must use groups_id instead of group name in the file you try to import...

[stonebuzz]

You must use groups_id instead of group name in the file you try to import...

Even if I put the group ID, it is not added to the list

[kabassanov]

Well, the bug we met was related to the user insertion during a group injection. In your case, it is a group insertion during a user injection. So it could be another bug...

[stonebuzz]

My bad, I didn't read the description correctly

[Hantiel]

@cconard96 :fix/group_user_import - Still same issue - Groups are imported without users. Anyone tested this solution ? because I don't know if I'm doing something wrong

[kabassanov]

@Hantiel, it worked for me at least with the first commit. Will try to check with the last 2 ones...
Could you show what your csv file looks like?

[Hantiel]

CSV
hantiel - login in GLPI

Mapping

I will very thankful for help - i need to migrate 300 group with different users / managers so any help will be unappreciated.

[kabassanov]

@Hantiel, the "issue" is that you have to use integer users_id (that GLPI previously gave to each inserted user) and not his name (login)...

[Hantiel]

Something Like that ? Mapping without changes?

Still same - user / manager are not added.
Im using fix/group_user_import version

[kabassanov]

Does-it work when you try to fill a non-manager
Do you have any relevant information in php-errors.log or sql-errors.log?

[cedric-anne]

I merged it as it relove a regression introduced in previous versions. Remaining bugs may not be really related to this.

[Hantiel]

I just install / copy actually develop version and same ;/

sql-error.log

[2022-09-14 13:24:24] glpisqllog.ERROR: DBmysql::query() in /var/www/html/glpi/src/DBmysql.php line 370
*** MySQL query error:
SQL: INSERT INTO glpi_groups_users (users_id, groups_id) VALUES (NULL, '139')
Error: Column 'users_id' cannot be null
Backtrace :
src/DBmysql.php:1312
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1304 CommonDBTM->addToDB()
...injection/inc/commoninjectionlib.class.php:1551 CommonDBTM->add()
...injection/inc/commoninjectionlib.class.php:1496 PluginDatainjectionCommonInjectionLib->effectiveAddOrUpdate()
...s/datainjection/inc/groupinjection.class.php:84 PluginDatainjectionCommonInjectionLib->processAddOrUpdate()
plugins/datainjection/inc/engine.class.php:147 PluginDatainjectionGroupInjection->addOrUpdateObject()
...datainjection/inc/clientinjection.class.php:267 PluginDatainjectionEngine->injectLine()
...datainjection/inc/clientinjection.class.php:219 PluginDatainjectionClientInjection::processInjection()
...datainjection/front/clientinjection.form.php:42 PluginDatainjectionClientInjection::showInjectionForm()
{"user":"7@GLPI_User"}
[2022-09-14 13:24:24] glpisqllog.ERROR: DBmysql::query() in /var/www/html/glpi/src/DBmysql.php line 370
*** MySQL query error:
SQL: INSERT INTO glpi_groups_users (is_manager, users_id, groups_id) VALUES ('1', NULL, '140')
Error: Column 'users_id' cannot be null
Backtrace :
src/DBmysql.php:1312
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1304 CommonDBTM->addToDB()
...injection/inc/commoninjectionlib.class.php:1551 CommonDBTM->add()
...injection/inc/commoninjectionlib.class.php:1496 PluginDatainjectionCommonInjectionLib->effectiveAddOrUpdate()
...s/datainjection/inc/groupinjection.class.php:84 PluginDatainjectionCommonInjectionLib->processAddOrUpdate()
plugins/datainjection/inc/engine.class.php:147 PluginDatainjectionGroupInjection->addOrUpdateObject()
...datainjection/inc/clientinjection.class.php:267 PluginDatainjectionEngine->injectLine()
...datainjection/inc/clientinjection.class.php:219 PluginDatainjectionClientInjection::processInjection()
...datainjection/front/clientinjection.form.php:42 PluginDatainjectionClientInjection::showInjectionForm()
{"user":"7@GLPI_User","mem_usage":"0.030", 4.42Mio)"}
[2022-09-14 13:24:24] glpisqllog.ERROR: DBmysql::query() in /var/www/html/glpi/src/DBmysql.php line 370
*** MySQL query error:
SQL: INSERT INTO glpi_groups_users (users_id, groups_id) VALUES (NULL, '141')
Error: Column 'users_id' cannot be null
Backtrace :
src/DBmysql.php:1312
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1304 CommonDBTM->addToDB()
...injection/inc/commoninjectionlib.class.php:1551 CommonDBTM->add()
...injection/inc/commoninjectionlib.class.php:1496 PluginDatainjectionCommonInjectionLib->effectiveAddOrUpdate()
...s/datainjection/inc/groupinjection.class.php:84 PluginDatainjectionCommonInjectionLib->processAddOrUpdate()
plugins/datainjection/inc/engine.class.php:147 PluginDatainjectionGroupInjection->addOrUpdateObject()
...datainjection/inc/clientinjection.class.php:267 PluginDatainjectionEngine->injectLine()
...datainjection/inc/clientinjection.class.php:219 PluginDatainjectionClientInjection::processInjection()
...datainjection/front/clientinjection.form.php:42 PluginDatainjectionClientInjection::showInjectionForm()
{"user":"7@GLPI_User","mem_usage":"0.017", 4.43Mio)"}

[cedric-anne]

Please open a new issue.

[Hantiel]

I just check this with Mapping - User and for User is working but after return to manager - same issue.

[kabassanov]

I just check this with Mapping - User and for User is working but after return to manager - same issue.

That is what I use, so I didn't check manager import...

[Hantiel]

I just check this with Mapping - User and for User is working but after return to manager - same issue.

That is what I use, so I didn't check manager import...

Oh. Okey my mistake. Ok thanks I will try do something with that.
Thanks for help