Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer "complete[name]" field for mapping with tier item; see #121 #122

Conversation

cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented Sep 7, 2018

Preserve only one option per linkfield, as mapping process is based on arrays indexed by linkfield.

This is a hack to handle behaviour explained in issue #121.

From most preferred to less desirable, the option chosen for each linkfield is:
"completename", else "name", else first option found

@loicbenoit
Copy link

Tested OK.

The only thing I would change is your comment, for clarity sake.

Original comment

Preserved option is "complename" if existing, or "name" if existing,
or first founded option for each linkfield.

Suggestion

From most preferred to less desirable, the option chosen for each linkfield is:
"completename", else "name", else first option found

Copy link

@loicbenoit loicbenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it announces.

@cedric-anne
Copy link
Contributor Author

Thanks for the feedback.

@cedric-anne cedric-anne merged commit 9a9843a into pluginsGLPI:develop Sep 7, 2018
@cedric-anne cedric-anne deleted the feature/use-name-options-in-priority branch September 7, 2018 14:04
@cedric-anne cedric-anne added this to the 2.6.3 milestone Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants