rename a few config options for consistency #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
options_consistency
branch
3 times, most recently
from
b315d1b to
d3119e3
Compare
config: * proxy-prefix -> proxy_prefix * google_group -> google_groups * github_team -> github_teams flags: * tls-cert -> tls-cert-file * tls-key -> tls-key-file flags always use dashes, config options always use underscores flags are singular if they can be specified multiple times, config options are plural if they take a list inspired by oauth2-proxy/oauth2-proxy#186 Co-authored-by: Joel Speed <[email protected]>
ploxiln
force-pushed
the
options_consistency
branch
from
d3119e3 to
f68d247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config:
flags:
flags always use dashes, config options always use underscores
flags are singular if they can be specified multiple times,
config options are plural if they take a list
inspired by oauth2-proxy/oauth2-proxy#186
Co-authored-by: Joel Speed [email protected]