Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite componentId to support react17 #2545

Merged

Conversation

Alex-Spike
Copy link
Contributor

Rewrite componentId to support react17
Issue: #2536

I fully understand the benefits of react useId hook but it doesn't work for react 17. As in new versions this lib resolved all vulnerabilities issues it will be great to support react 17 as well. I’ve just rewritten it to "lodash/uniqueId" and then it can be supported for all versions.

Thank you

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 5:01pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3a7b972:

Sandbox Source
nivo Configuration

@the-marolie
Copy link

@plouc , would be great if this could be merged and released.

@adelsz
Copy link

adelsz commented Apr 8, 2024

Thanks for the PR, waiting for this to land

@rociogarridofer
Copy link

Hello! When will we be able to enjoy these changes? Thanks!

Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc
Copy link
Owner

plouc commented Apr 23, 2024

Thank you for the fix @Alex-Spike!

@plouc plouc merged commit 831d28d into plouc:master Apr 23, 2024
5 checks passed
@plouc plouc mentioned this pull request Apr 23, 2024
@Alex-Spike
Copy link
Contributor Author

Thank you for pushing these changes into the package @plouc!

@Alex-Spike Alex-Spike deleted the rewrite-componentId-to-support-react17 branch April 23, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants