Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Line): passing the full Point info to the AccessorFunc for Label #2541

Merged
merged 1 commit into from
May 1, 2024

Conversation

akassaei
Copy link
Contributor

💥 Breaking change
This is a rework PR for what was proposed for #1981 .

We achieve the same goal but instead pass the whole Point informations to the AccessorFunc directly.
Compared to the first version of the PR, this one comes with :

  • Updates related to the Website to not break existing examples
  • Unit tests for the case with a function and the case with a string passed to the pointLabel prop

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:01pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f308279:

Sandbox Source
nivo Configuration

@dubzzz
Copy link
Contributor

dubzzz commented Apr 30, 2024

@plouc Sorry for the direct ping, but I feel this new version of #1981 follows your recommendations done at #1981 (comment). Anything to change?

@plouc plouc merged commit 1ac1246 into plouc:master May 1, 2024
3 checks passed
@plouc
Copy link
Owner

plouc commented May 1, 2024

Thank you @dubzzz and @akassaei!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants