Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(line): add support for onSliceClick #2187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukeharvey
Copy link

Adds an onClick callback for Line chart slices. We found this approach useful so wanted to share it.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95ab28d:

Sandbox Source
nivo Configuration

@fspin
Copy link

fspin commented Jan 11, 2023

This: #2128 and this: #1401 are also related.
It will be great indeed, if one of these PR could be merged! 🙏

@Brevan4
Copy link

Brevan4 commented Jan 24, 2023

Can you please tell us when you're planning to release this? This is required for our project.

@un-neil
Copy link

un-neil commented Mar 31, 2023

+1

@plouc can we get this merged, please?

@WhyBeeKay
Copy link

I second what @un-neil said above - can we get this merged please? It would make my life a lot simpler @plouc

@stale
Copy link

stale bot commented Aug 7, 2023

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Aug 7, 2023
@lukeharvey
Copy link
Author

Bump

@stale stale bot removed the stale label Aug 7, 2023
Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Dec 15, 2023
@lukeharvey
Copy link
Author

Bump again

@stale stale bot removed the stale label Dec 16, 2023
Copy link

stale bot commented Mar 17, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Mar 17, 2024
@stale stale bot removed the stale label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants