feat(legends): init SizeLegendSvg

plouc · Dec 16, 2017 · 22c186a · 22c186a
1 parent f316606
commit 22c186a
Show file tree

Hide file tree

Showing 13 changed files with 9,333 additions and 5 deletions.
diff --git a/packages/nivo-circle-packing/package.json b/packages/nivo-circle-packing/package.json
@@ -7,6 +7,7 @@
   "jsnext:main": "es/index.js",
   "dependencies": {
     "@nivo/core": "0.33.0",
+    "@nivo/legends": "0.33.0",
     "d3-hierarchy": "^1.1.5",
     "react-motion": "^0.5.2",
     "recompose": "^0.26.0"

diff --git a/packages/nivo-circle-packing/src/Bubble.js b/packages/nivo-circle-packing/src/Bubble.js
@@ -9,8 +9,7 @@
 import React from 'react'
 import { TransitionMotion, spring } from 'react-motion'
 import pick from 'lodash/pick'
-import { colorMotionSpring, getInterpolatedColor } from '@nivo/core'
-import { Container, SvgWrapper } from '@nivo/core'
+import { colorMotionSpring, getInterpolatedColor, Container, SvgWrapper } from '@nivo/core'
 import enhance from './enhance'
 import { nodeWillEnter, nodeWillLeave } from './motion'
 import { getNodeHandlers } from './interactivity'

diff --git a/packages/nivo-legends/package.json b/packages/nivo-legends/package.json
@@ -12,9 +12,12 @@
   "devDependencies": {
     "@nivo/babel-preset": "0.33.0",
     "babel-cli": "^6.26.0",
-    "babel-jest": "^20.0.3",
-    "cross-env": "^5.0.5",
-    "jest": "^21.0.1",
+    "babel-eslint": "^8.0.3",
+    "babel-jest": "^21.2.0",
+    "cross-env": "^5.1.1",
+    "eslint": "^4.12.1",
+    "eslint-plugin-react": "^7.5.1",
+    "jest": "^21.2.1",
     "react": "^16.2.0",
     "react-dom": "^16.2.0",
     "react-test-renderer": "^16.2.0"
@@ -27,6 +30,7 @@
     "access": "public"
   },
   "scripts": {
+    "lint": "eslint src stories tests",
     "test": "jest --verbose ./tests",
     "test:cover": "jest --verbose --coverage ./tests",
     "build:commonjs": "rm -rf lib && cross-env NODE_ENV=commonjs babel src --out-dir lib",

diff --git a/packages/nivo-legends/src/constants.js b/packages/nivo-legends/src/constants.js
@@ -19,7 +19,24 @@ export const ANCHOR_LEFT = 'left'
 export const ANCHOR_TOP_LEFT = 'top-left'
 export const ANCHOR_CENTER = 'center'
 
+export const POSITION_TOP = 'top'
+export const POSITION_RIGHT = 'right'
+export const POSITION_BOTTOM = 'bottom'
+export const POSITION_LEFT = 'left'
+
+export const DIRECTION_TOP_LEFT = 'top-left'
+export const DIRECTION_TOP_RIGHT = 'top-right'
+export const DIRECTION_RIGHT_TOP = 'right-top'
+export const DIRECTION_RIGHT_BOTTOM = 'right-bottom'
+export const DIRECTION_BOTTOM_LEFT = 'bottom-left'
+export const DIRECTION_BOTTOM_RIGHT = 'bottom-right'
+export const DIRECTION_LEFT_TOP = 'left-top'
+export const DIRECTION_LEFT_BOTTOM = 'left-bottom'
+
 export const DIRECTION_LEFT_TO_RIGHT = 'left-to-right'
 export const DIRECTION_RIGHT_TO_LEFT = 'right-to-left'
 export const DIRECTION_TOP_TO_BOTTOM = 'top-to-bottom'
 export const DIRECTION_BOTTOM_TO_TOP = 'bottom-to-top'
+
+export const SHAPE_SQUARE = 'square'
+export const SHAPE_CIRCLE = 'circle'
diff --git a/packages/nivo-legends/src/svg/BoxLegendSvg.js b/packages/nivo-legends/src/svg/BoxLegendSvg.js
@@ -87,6 +87,12 @@ const BoxLegendSvg = ({
 }
 
 BoxLegendSvg.propTypes = {
+    data: PropTypes.arrayOf(
+        PropTypes.shape({
+            label: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
+            fill: PropTypes.string.isRequired,
+        })
+    ).isRequired,
     containerWidth: PropTypes.number.isRequired,
     containerHeight: PropTypes.number.isRequired,
     translateX: PropTypes.number.isRequired,

diff --git a/packages/nivo-legends/src/svg/LegendSvg.js b/packages/nivo-legends/src/svg/LegendSvg.js
@@ -38,6 +38,7 @@ const LegendSvg = ({
     symbolSpacing,
     symbolShape,
 }) => {
+    // eslint-disable-next-line no-unused-vars
     const { width, height, padding } = computeDimensions({
         itemCount: data.length,
         itemWidth,