feat(labels): use alignmentBaseline instead of approximative dy

plouc · Aug 19, 2017 · 10aa40f · 10aa40f
1 parent 755783d
commit 10aa40f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/src/components/charts/bubble/Bubble.js b/src/components/charts/bubble/Bubble.js
@@ -22,7 +22,6 @@ const createNodes = ({
     labelFormat,
     labelSkipRadius,
     labelTextColor,
-    labelTextDY,
 }) => {
     const label = getLabelGenerator(_label, labelFormat)
     const borderColorFn = getColorGenerator(borderColor)
@@ -47,7 +46,6 @@ const createNodes = ({
                 <circle
                     key={`${node.key}.circle`}
                     r={node.style.r}
-                    className="nivo_bubble_node"
                     transform={`translate(${node.style.x},${node.style.y})`}
                     onMouseEnter={handleTooltip}
                     onMouseMove={handleTooltip}
@@ -73,10 +71,9 @@ const createNodes = ({
                     renderedNodes.push(
                         <text
                             key={`${node.key}.text`}
-                            className="nivo_bubble_legend"
                             transform={`translate(${node.style.x},${node.style.y})`}
-                            textAnchor={'middle'}
-                            dy={labelTextDY}
+                            textAnchor="middle"
+                            alignmentBaseline="central"
                             style={{
                                 fill: textColorFn(node.style),
                                 pointerEvents: 'none',

diff --git a/src/components/charts/bubble/BubbleProps.js b/src/components/charts/bubble/BubbleProps.js
@@ -66,7 +66,6 @@ export const bubbleDefaultProps = {
     enableLabel: true,
     label: 'id',
     labelTextColor: 'inherit:darker(1)',
-    labelTextDY: 5,
     labelSkipRadius: 0,
 
     // transitions

diff --git a/src/components/charts/treemap/TreeMapNode.js b/src/components/charts/treemap/TreeMapNode.js
@@ -42,7 +42,7 @@ const TreeMapNode = ({
         {hasLabel &&
             <text
                 textAnchor="middle"
-                dy="0.5em"
+                alignmentBaseline="central"
                 style={{ fill: labelTextColor, pointerEvents: 'none' }}
                 transform={`translate(${width / 2},${height / 2}) rotate(${labelRotation})`}
             >