Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh #1172

Merged
merged 41 commits into from
Sep 14, 2023
Merged

Refresh #1172

merged 41 commits into from
Sep 14, 2023

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Sep 7, 2023 •
edited
Loading

@dmt0 dmt0 requested a review from alexcjohnson September 7, 2023 21:40
@dmt0
Copy link
Contributor Author

dmt0 commented Sep 7, 2023

Hey @alexcjohnson, this one is ready for review. Once this is reviewed and merged I'll make a release.

Looks like Percy didn't keep the old screenshots and counts these as brand new initial ones. Would be great if you'd approve them, so we have a reference for future work.

@dmt0 dmt0 mentioned this pull request Sep 7, 2023
Closed
alexcjohnson
alexcjohnson reviewed Sep 11, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson reviewed Sep 11, 2023
View reviewed changes
babel.config.json Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson reviewed Sep 12, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@alexcjohnson
Copy link
Collaborator

@dmt0 this looks great. Just had a couple of small suggestions, and it looks like whatever the issue was with Percy has been resolved and it's happy now ☺️

@dmt0 dmt0 force-pushed the refresh branch 3 times, most recently from 62d41d6 to e3de3b5 Compare September 13, 2023 21:51
alexcjohnson
alexcjohnson approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 great stuff @dmt0!

@dmt0 dmt0 merged commit 8097fbd into master Sep 14, 2023
@dmt0 dmt0 deleted the refresh branch September 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing translation keys sass-loader past 7.1.0 does not work Dev app doesn't work in IE
2 participants
@dmt0 @alexcjohnson