Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size V3 #688

Closed
wants to merge 4 commits into from
Closed

Reduce size V3 #688

wants to merge 4 commits into from

Conversation

fu
Copy link

@fu fu commented Feb 6, 2017

Hi,

updated pull request. See #501 for more details.

Cheers

.c

@jonmmease jonmmease added this to the v3.4.0 milestone Sep 28, 2018
@jonmmease
Copy link
Contributor

This functionality is being added in #1234 using a slightly different approach. With this PR, the include_plotlyjs argument to plotly.offline.plot accepts a few options in addition to True and False. In particular, setting include_plotlyjs='directory' results in the behavior of this PR (a copy of plotly.min.js is copied to the output directory if it does not already exist, and the script tag references this local copy).

I'd like to avoid having this be a one-off global flag for the time being. Eventually I hope we'll be able to revamp our settings system a bit to make it possible to register default values for options like include_plotlyjs.

Thanks for your work on this @fu, the include_plotlyjs='directory' option wouldn't have been included in #1234 without it!

@jonmmease jonmmease closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants