Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prebuilt assets when installing from sdist #3231

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

fcollonval
Copy link
Contributor

Fixes #3230

@fcollonval
Copy link
Contributor Author

I tested it locally by changing the setup.py in the tar.gz.

It may be worth adding some tests.

@nicolaskruchten
Copy link
Contributor

Thank you again! I'll get this rolled into the next RC

@nicolaskruchten
Copy link
Contributor

A couple of additional questions for you in terms of expected behaviour:

  1. is it normal that pip install -e . does not install the extension?
  2. what does a user need to restart after installing? refresh the frontend? restart the kernel? clear notebook outputs? restart JupyterLab?

@nicolaskruchten nicolaskruchten merged commit 8f6dc80 into plotly:master Jun 11, 2021
@fcollonval fcollonval deleted the patch-1 branch June 12, 2021 07:43
@fcollonval
Copy link
Contributor Author

  • is it normal that pip install -e . does not install the extension?

To achieve that, the setup command will need to be modified (by default the editable mode does not copy any files in the python system tree). But I'm not sure this is the best idea. I would recommend running these two commands instead:

pip install -e .
jupyter labextension develop . --overwrite

See documentation

  • what does a user need to restart after installing? refresh the frontend? restart the kernel? clear notebook outputs? restart JupyterLab?

If plotly was not installed, they need to restart the kernel and refresh the frontend.

@nicolaskruchten
Copy link
Contributor

Thanks! I'm hoping to release this this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5.0.0rc2] Source tarball installation failed
2 participants