Propagate empty templates #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense to me I think! |
|
Would it be possible to add a test which would have failed before this change? Like checking for a potential override of the template? Otherwise, 💃 (we can also add the test later -- if it makes sense to you) |
@nicolaskruchten I don't remember exactly which use-cases you were having trouble with, are there any particular tests that you'd like to have in here? |
|
The original issue was #1870 so it was with |
|
Ok, I'll go ahead and merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a template is explicitly set to
{}, it is now replaced by{"data": {"scatter": [{}]}}so that it will not get overridden by a default template when a figure is passed along to other functions/libraries.cc @nicolaskruchten