Handle optional import where imported module raises exception on import #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log exception but don't raise
jonmmease
commented
Sep 25, 2018
| import unittest.mock as mock | ||
| else: | ||
| import mock | ||
|
|
There was a problem hiding this comment.
Mock is not used here
plotly/optional_imports.py
Outdated
| _not_importable.add(name) | ||
| msg = "Error importing optional module {}".format(name) | ||
| logger.exception(msg) | ||
| # logger.error(msg) |
There was a problem hiding this comment.
Remove this comment
plotly/optional_imports.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
| print(__name__) |
There was a problem hiding this comment.
Remove print statement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #696