Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca integration for static image export #1120

Merged
merged 82 commits into from
Aug 25, 2018
Merged

Orca integration for static image export #1120

merged 82 commits into from
Aug 25, 2018

Commits on Aug 11, 2018

  1. Configuration menu
    Copy the full SHA
    9ffd55a View commit details
    Browse the repository at this point in the history
  2. Added simple pyqt5 window backend

    Works in QtConsole if you initialize the qt event loop with:
    
    from PyQt5.QtWebEngineWidgets import QWebEngineView
    %gui qt
    
    QWebEngineView import must precede the %gui qt command.
    jonmmease committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    de10887 View commit details
    Browse the repository at this point in the history
  3. Added OrcaStatus singleton to hold status of orca server process

    Added orca server process management tests
    jonmmease committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    38127fa View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2018

  1. More progress on the orca module.

     - Save/load settings from ~/.plotly/.orca file
     - More validation
     - write image
     - add image options (format, size, scale)
    jonmmease committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    fd32d64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49130b1 View commit details
    Browse the repository at this point in the history
  3. Remove unused import

    jonmmease committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    264d19b View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. Remove autostart and hostname configuration parameters

    Lets save some complexity and not support using an external orca
    server for now.
    jonmmease committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    9b6f8c8 View commit details
    Browse the repository at this point in the history
  2. Docstrings and cleanup

    jonmmease committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    8d31c9b View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Kill the orca server process using psutil

    The old approach required OS-specific process management and it still
    didn't kill the child process for orca installed with npm.  Now
    all of the OS-specifics are in psutil.
    
    psutil is an optional import that is check when the server is first
    requested.
    jonmmease committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    341d145 View commit details
    Browse the repository at this point in the history
  2. Don't auto import any of the show/backend logic

    We could leave the plotly.io._show module in place, so people could
    experiment with the image backend concept.
    jonmmease committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    af10ff6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb21a70 View commit details
    Browse the repository at this point in the history
  4. Capture server process output.

    It emits some errors when children are killed, but these are harmless
    jonmmease committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    0183d43 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2018

  1. Configuration menu
    Copy the full SHA
    f75652c View commit details
    Browse the repository at this point in the history
  2. Initial Python 2 support

    jonmmease committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    fd3e65c View commit details
    Browse the repository at this point in the history
  3. Run orca auto-shutdown timer as daemon thread

    This way program exist won't wait for it to complete
    jonmmease committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    15e62a0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d5a074 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2df38cc View commit details
    Browse the repository at this point in the history
  6. Point orca to packaged (offline) plotly.js and topojson and (online) …

    …Mathjax CDN
    
     - Add topojson files to `plotly/package_data`
     - Add new config settings for plotly.js bundle (use local by default), topojson, mathjax, and mapbox access token
     - Add image tests for `topojson` images and mathjax images
     - Remove saving of orca config to ~/.plotly. Need more a more wholistic settings solution that handles environments
     - Shutdown server when setting config parameters that won't be active until server restarts (e.g. plotlyjs bundle)
     - Make default timeout None. So shutting down the server due to inactivity is now opt-in.
    jonmmease committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    68e6465 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. Configuration menu
    Copy the full SHA
    0d1e0eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f81e63c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f78063 View commit details
    Browse the repository at this point in the history
  4. Forgot && in tox command

    jonmmease committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    fc35eff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    48d4de5 View commit details
    Browse the repository at this point in the history
  6. Local install in tox

    jonmmease committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    88b293a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    86fc540 View commit details
    Browse the repository at this point in the history
  8. whitelist ls and echo

    jonmmease committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    702dd59 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    196b58b View commit details
    Browse the repository at this point in the history
  10. If search for orca fails, try orca.js. Also display search path

    details in error message.
    jonmmease committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    2f08714 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2217628 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a6a255a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e8bc4eb View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1207e71 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7d3e244 View commit details
    Browse the repository at this point in the history
  16. Remove debugging assertion

    jonmmease committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    6fc596c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    bfd7ff8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b212564 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    dc7cf36 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Configuration menu
    Copy the full SHA
    192953b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a756f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d29da80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ce2115 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7a75478 View commit details
    Browse the repository at this point in the history
  6. Install all main repo dependencies in one command

    Should keep Python version constrained and be a bit faster.
    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    42be57e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d213f86 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3a73dfc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f9b0133 View commit details
    Browse the repository at this point in the history
  10. Try to make reference images more reproducible

     - Remove text (Except for latex)
     - Fix width/height
    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    62583c9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1830594 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4ce674d View commit details
    Browse the repository at this point in the history
  13. Reinstate save/load settings with a few changes since last time:

     - plotlyjs is now a constant
     - topojson now points to CDN by default
    
     So now, default settings aren't specific to a particular environment.
     And if someone changes a setting, the change makes sense across
     environments.
    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    a50a5bf View commit details
    Browse the repository at this point in the history
  14. Don't run optional tests in orca workflow, just core and orca.

    This greatly reduces the number of dependencies needed.
    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    2c42fca View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    37dcf76 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f30e247 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    80f52c7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6bfca05 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    c9d5832 View commit details
    Browse the repository at this point in the history
  20. Change 3.4 to 3.5 work around conda package dependency issues

    Try downloading miniconda 3 for Python 2 workflow
    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    79f89e1 View commit details
    Browse the repository at this point in the history
  21. Fix workflow name

    jonmmease committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    f44aea3 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    32630a1 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    aacc203 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Configuration menu
    Copy the full SHA
    133cb24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fa866b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cff8f1c View commit details
    Browse the repository at this point in the history
  4. Add validate option to to_image and write_image

    to bypass figure dict validation.
    
    Also improve presentation of orca error messages and added a special
    check for EPS failures that might be due to the needed poppler
    dependency
    jonmmease committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    9c70b3a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Added more helpful (at least friendlier) error message when plotly.py…

    … fails to communicate
    
    with the orca server process.
    jonmmease committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    8d97381 View commit details
    Browse the repository at this point in the history
  2. Add poppler dependency to circle conda environment

    Needed for EPS tests
    jonmmease committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    c58d688 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8967568 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c5dd2f3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dab4e14 View commit details
    Browse the repository at this point in the history
  6. Re-enable all tests

    jonmmease committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    3137b0c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    005299f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5f8b813 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Configuration menu
    Copy the full SHA
    94c1bab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b4fc0c View commit details
    Browse the repository at this point in the history
  3. Python 2 test fix [ci skip]

    jonmmease committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    54d38d4 View commit details
    Browse the repository at this point in the history
  4. Use status.executable when building the orca command.

    On windows, this avoids Popen being unable to find the orca executable
    when it is on the environment path. [ci skip]
    jonmmease committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    f38beb5 View commit details
    Browse the repository at this point in the history
  5. Use os.pathset so we don't mess up Windows paths

    [skip ci]
    jonmmease committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    e383c57 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2018

  1. Add helpful message when orca returns a 'plotly.js error' on mapbox

    If orca returns a 525: 'plotly.js error', and the figure contains
    at least one mapbox trace, and not mapbox_access_token is configured,
    then include a error message explaining what to do.
    jonmmease committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    88b37a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a0adac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f37682f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d8958aa View commit details
    Browse the repository at this point in the history
  5. Full PR review

    jonmmease committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    25f1f81 View commit details
    Browse the repository at this point in the history