Fix interacting with selection on subplots with overlaid axes

[Farkites]

Fixes #6530

Description

Extending an existing box/lasso selection on traces that overlay axes don't update selection. Only the first trace (which doesn't have overlay is updated). See video below:
https://github.com/plotly/plotly.js/assets/35932204/91f75734-f47d-47b6-81b0-806413b2cf45

This was happening because the yAxisIds is equal to 'y' and trace.yaxis to y + the index of the trace (e.g y4), so yAxisIds.indexOf(trace.yaxis) is -1 for all the overlaying traces.

[archmoj]

Very interesting proposed fix.
It looks like we also select traces in other subplots that are not overlay with these axes.
If that's the case we shouldn't include them.

[Farkites]

I have checked all the other test cases with subplots and the selection seems to be working fine.

The only cases I've found where there are some crossover with selection/deselection are with:

• plot_types
• plot_types_grid_dash
• box_plot_jitter_edge_cases
• mapbox_choropleth-multiple

And for these the issues happen with and without my changes.

[archmoj]

@Farkites Thanks very much for your tests.
Here we need to know if we have two subplots i.e. (xy + xy2 ) and (x2y3 + x2,y4) and the user reselects over the first one; then are the traces in the second subplot (x2y3) are also re-selected before and after this change?

[Farkites]

@archmoj Yes, in that scenario the traces in the second subplot (x2y3) are re-selected before and after the changes. You can check this here:

• Before changes: https://codepen.io/Mario-Rodr-guez-Ib-ez/pen/ExMEbdK
• After changes: https://codepen.io/Mario-Rodr-guez-Ib-ez/pen/QWoQoao

[archmoj]

Thanks very much for all these manual tests and the brilliant fix.
I am tempted to include this in the next plotly.js minor which is coming out today.
So I'll approve it now.

💃 💃

Please open a follow up PR to include jasmine tests to lock down the bug.
You may place new tests in test/jasmine/tests/select_test.js
Thank you!

[archmoj]

@Farkites One more request before merging this.
Please create a draft log file.