Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Chart2Music keyboard and sound accessibility features #6680
base: master
Are you sure you want to change the base?
add Chart2Music keyboard and sound accessibility features #6680
Changes from 65 commits
6fb9c65
87b4c5c
64ae505
d37d24f
d0467bb
3a73776
b4df959
97b608f
6205d62
7e40cde
6d9185b
935cf54
44deae2
c38ab67
c6a27be
cac174c
159ca1b
7467a47
08b820b
41b0fb9
94e25c3
61ea8ce
c9a0b91
cc92639
7baa0d3
3127dee
2429e55
00572e8
30f4e11
247b301
d08adfb
dbce5da
e1f9563
3f4ab54
92d97b7
6b2dcc9
b5bb517
25ca44a
7328324
00b2750
b04bb17
d4bd71b
af2ff80
80b4cf3
ee99f35
3841640
d84d108
0c43407
4c75035
3c49ed6
f7be666
4a260af
f67c513
41baab9
26754b7
ed18907
1e4bcef
2c1abf4
614fb8b
5f5e599
fe9736e
59ad5c6
d18c584
043d408
129eb3b
acc8517
c5ad240
0113d90
771029e
bfbbbf1
cadfd7f
56e582d
8e55f98
86d75d8
15671b0
057e067
44f7ad3
8e3b62b
aed1e02
1777fba
3a0384f
dba0b53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate on this? @ayjayt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi sorry! I just fixed my github notifications today
Line 10: there is a function
Lib.getGraphDiv()
that seems to coercegd
to be a "real"gd
but I'm not sure when its needed.Line 20: Me not knowing the different "levels" of plotly's rendering functions (fullReset being a full-rerender, but there are shortcuts) had previously caused bugs, so my basic question is "When do we actually need to re-initialize C2M besides a fullReset?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getGraphDiv
is for functions to be called by end users, so that they can pass in the ID of their graph div as a string, as an alternative to passing in the DOM element directly. Functions called only by our code do not need this step. Which kind isinitC2M
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archmoj Is that accurate that title or title.text could contain the information needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preferred way of setting a title is via
title.text
nottitle
.Setting
title
to a string is discouraged(& deprecated) but may still widely used in our codes.We may handle case of
title
in case title is set to a string instead of an object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop support for that!