Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement layout.legend.orientation (closes #53) #535

Merged
merged 19 commits into from
May 17, 2016

Commits on May 13, 2016

  1. Configuration menu
    Copy the full SHA
    ff16df1 View commit details
    Browse the repository at this point in the history
  2. Simplify signature of drawTexts in legend

    * Removed unused `i`.
    
    * Passed `legendItem` directly.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    ddc6d71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f40dbd4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    92ff540 View commit details
    Browse the repository at this point in the history
  5. Legend: refactor computation of text dimensions

    * Checked that all jasmine and image tests still pass.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    869538c View commit details
    Browse the repository at this point in the history
  6. Legend: set tspan.line's x in the callback

    * Set tspan.line's x in the callback to convertToSpans, otherwise they
      won't be set in the first render.
    
    * Checked all jasmine and image tests still pass.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    b2538e1 View commit details
    Browse the repository at this point in the history
  7. Legend: set tspan.line's x before expandMargin

    * Ensure the position of the `tspan.line`s is set before computing the
      legend dimensions and expanding the margins.
    
    * The baseline image for `pseudo_html.json` needed updating because it
      has a multi-line legend.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    9dc2609 View commit details
    Browse the repository at this point in the history
  8. Legend: compute size only after drawing texts

    * This change not only improves drawing performance, but it will also
      allows for `drawTexts` to be moved to `styles.js`.
    
    * Checked all jasmine and image tests still pass.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    f68344b View commit details
    Browse the repository at this point in the history
  9. Legend: move placing of groups and traces together

    * Moved the placing of legend groups to `computeLegendDimensions` so
      that they are handled along with the placing of legend traces.
    
    * This change is a preliminary step to implement horizontal legends.
    
    * Checked all jasmine and image tests still pass.
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    c0dfc8a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e5049c9 View commit details
    Browse the repository at this point in the history
  11. Legend: add mocks with horizontal legends

    * Added `legend_horizontal.json` (a mock with a horizontal legend
      without groups).
    
    * Added `legend_horizontal_groups.json` (a mock with a grouped
      horizontal legend).
    n-riesco committed May 13, 2016
    Configuration menu
    Copy the full SHA
    23e3972 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2016

  1. Legend: Use D3 to invoke functions

    * Used `selection.call()` to invoke drawTexts, setupTraceToggle and
      computeTextDimentions.
    n-riesco committed May 17, 2016
    Configuration menu
    Copy the full SHA
    25c2970 View commit details
    Browse the repository at this point in the history
  2. Legend: Use Lib.setTranslate

    n-riesco committed May 17, 2016
    Configuration menu
    Copy the full SHA
    7d502fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    107883a View commit details
    Browse the repository at this point in the history
  4. Legend: Remove legendItem from function signatures

    * Removed legendItem from the function signatures of drawTexts,
      setupTraceToggle and computeTextDimensions.
    n-riesco committed May 17, 2016
    Configuration menu
    Copy the full SHA
    65aa6c0 View commit details
    Browse the repository at this point in the history
  5. Legend: set default position of horizontal legends

    * Position horizontal legends on the bottom left, unless a range slider
      is present.
    
    * If a range slider is present, position the horizontal legend on the
      top left.
    n-riesco committed May 17, 2016
    Configuration menu
    Copy the full SHA
    8c6d47a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc20390 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c1632d4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    313976d View commit details
    Browse the repository at this point in the history