-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement layout.legend.orientation
(closes #53)
#535
Commits on May 13, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ff16df1 - Browse repository at this point
Copy the full SHA ff16df1View commit details -
Simplify signature of drawTexts in legend
* Removed unused `i`. * Passed `legendItem` directly.
Configuration menu - View commit details
-
Copy full SHA for ddc6d71 - Browse repository at this point
Copy the full SHA ddc6d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for f40dbd4 - Browse repository at this point
Copy the full SHA f40dbd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92ff540 - Browse repository at this point
Copy the full SHA 92ff540View commit details -
Legend: refactor computation of text dimensions
* Checked that all jasmine and image tests still pass.
Configuration menu - View commit details
-
Copy full SHA for 869538c - Browse repository at this point
Copy the full SHA 869538cView commit details -
Legend: set tspan.line's x in the callback
* Set tspan.line's x in the callback to convertToSpans, otherwise they won't be set in the first render. * Checked all jasmine and image tests still pass.
Configuration menu - View commit details
-
Copy full SHA for b2538e1 - Browse repository at this point
Copy the full SHA b2538e1View commit details -
Legend: set tspan.line's x before expandMargin
* Ensure the position of the `tspan.line`s is set before computing the legend dimensions and expanding the margins. * The baseline image for `pseudo_html.json` needed updating because it has a multi-line legend.
Configuration menu - View commit details
-
Copy full SHA for 9dc2609 - Browse repository at this point
Copy the full SHA 9dc2609View commit details -
Legend: compute size only after drawing texts
* This change not only improves drawing performance, but it will also allows for `drawTexts` to be moved to `styles.js`. * Checked all jasmine and image tests still pass.
Configuration menu - View commit details
-
Copy full SHA for f68344b - Browse repository at this point
Copy the full SHA f68344bView commit details -
Legend: move placing of groups and traces together
* Moved the placing of legend groups to `computeLegendDimensions` so that they are handled along with the placing of legend traces. * This change is a preliminary step to implement horizontal legends. * Checked all jasmine and image tests still pass.
Configuration menu - View commit details
-
Copy full SHA for c0dfc8a - Browse repository at this point
Copy the full SHA c0dfc8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5049c9 - Browse repository at this point
Copy the full SHA e5049c9View commit details -
Legend: add mocks with horizontal legends
* Added `legend_horizontal.json` (a mock with a horizontal legend without groups). * Added `legend_horizontal_groups.json` (a mock with a grouped horizontal legend).
Configuration menu - View commit details
-
Copy full SHA for 23e3972 - Browse repository at this point
Copy the full SHA 23e3972View commit details
Commits on May 17, 2016
-
Legend: Use D3 to invoke functions
* Used `selection.call()` to invoke drawTexts, setupTraceToggle and computeTextDimentions.
Configuration menu - View commit details
-
Copy full SHA for 25c2970 - Browse repository at this point
Copy the full SHA 25c2970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d502fa - Browse repository at this point
Copy the full SHA 7d502faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 107883a - Browse repository at this point
Copy the full SHA 107883aView commit details -
Legend: Remove legendItem from function signatures
* Removed legendItem from the function signatures of drawTexts, setupTraceToggle and computeTextDimensions.
Configuration menu - View commit details
-
Copy full SHA for 65aa6c0 - Browse repository at this point
Copy the full SHA 65aa6c0View commit details -
Legend: set default position of horizontal legends
* Position horizontal legends on the bottom left, unless a range slider is present. * If a range slider is present, position the horizontal legend on the top left.
Configuration menu - View commit details
-
Copy full SHA for 8c6d47a - Browse repository at this point
Copy the full SHA 8c6d47aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc20390 - Browse repository at this point
Copy the full SHA bc20390View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1632d4 - Browse repository at this point
Copy the full SHA c1632d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 313976d - Browse repository at this point
Copy the full SHA 313976dView commit details