Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Winkel Tripel projection #492

Merged
merged 5 commits into from
May 9, 2016
Merged

Add support for Winkel Tripel projection #492

merged 5 commits into from
May 9, 2016

Conversation

chriddyp
Copy link
Member

@chriddyp chriddyp commented Apr 30, 2016

the winkel tripel projection minimizes distortions in shape, flexion, and skewness. It's also the recommended projection from the cartographers at National Geographic.

I'd like to make this projection available as a default in Plotly 2.0 :)

@etpinard
Copy link
Contributor

etpinard commented May 2, 2016

👍 That's a dope projection:

image

http://bl.ocks.org/mbostock/3682676

In order to get it in plotly.js, we'll need to update src/plots/geo/projections.js using my d3-geo-projection-picker. By the way, I don't want to make d3-geo-projection-picker a plotly.js dependency because of its nasty postinstall hook.

@chriddyp feel free to give it a shot or I'll can get to it at some point this week.

@etpinard
Copy link
Contributor

etpinard commented May 6, 2016

@chriddyp hope you like it:

image

@etpinard
Copy link
Contributor

etpinard commented May 6, 2016

@mdtusz would you mind reviewing this. Thanks

@@ -405,6 +406,39 @@ function addProjectionToD3() {
(d3.geo.sinusoidal = function() {
return projection(sinusoidal);
}).raw = sinusoidal;
function aitoff(λ, φ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh...

@etpinard etpinard merged commit 106e52c into master May 9, 2016
@etpinard etpinard deleted the winkel-tripel branch May 9, 2016 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants