-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make surface contour highlights on hover toggleable #459
Conversation
- highlightColor -> highlightcolor - hightlightWidth -> highlightwidth - add backward compatibility block in cleanData and tests
@@ -20,8 +20,12 @@ function makeContourProjAttr(axLetter) { | |||
role: 'info', | |||
dflt: false, | |||
description: [ | |||
'Sets whether or not the dynamic contours are projected', | |||
'along the', axLetter, 'axis.' | |||
'Determines whether or not these contour lines are projected', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cldougl (or someone else from the doc team) could you review ⬇️ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear to me!
- so that tests can run on gl-less environments e.g. CircleCI.
@@ -711,8 +711,12 @@ describe('Test plot api', function() { | |||
} | |||
}]; | |||
|
|||
spyOn(Plots.subplotsRegistry.gl3d, 'plot'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Shame about the attribute name typo, but such is life. 💃 |
@mdtusz @cldougl
In brief
This PR:
surface
contour highlights on hover toggleable through thecontours.?.highlight
attribute (we weren't updating the correctgl-surface3d
property).highlightColor
is nowhighlightcolor
andhighlightWidth
is nowhighlightwidth
. A backward compatibility block is added.Color.defaultLine
as default (like everybody else 😃 ).surface
attribute descriptions.