Make surface contour highlights on hover toggleable #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- highlightColor -> highlightcolor - hightlightWidth -> highlightwidth - add backward compatibility block in cleanData and tests
| @@ -20,8 +20,12 @@ function makeContourProjAttr(axLetter) { | |||
| role: 'info', | |||
| dflt: false, | |||
| description: [ | |||
| 'Sets whether or not the dynamic contours are projected', | |||
| 'along the', axLetter, 'axis.' | |||
| 'Determines whether or not these contour lines are projected', | |||
There was a problem hiding this comment.
@cldougl (or someone else from the doc team) could you review ⬇️ ?
- so that tests can run on gl-less environments e.g. CircleCI.
| @@ -711,8 +711,12 @@ describe('Test plot api', function() { | |||
| } | |||
| }]; | |||
|
|
|||
| spyOn(Plots.subplotsRegistry.gl3d, 'plot'); | |||
|
Looks good to me! Shame about the attribute name typo, but such is life. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz @cldougl
In brief
This PR:
surfacecontour highlights on hover toggleable through thecontours.?.highlightattribute (we weren't updating the correctgl-surface3dproperty).highlightColoris nowhighlightcolorandhighlightWidthis nowhighlightwidth. A backward compatibility block is added.Color.defaultLineas default (like everybody else 😃 ).surfaceattribute descriptions.